Improve deployment error handling and disable vim#55
Improve deployment error handling and disable vim#55AronNovak wants to merge 2 commits intodigitallyinduced:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
I think we should ideally find how to disable vim entirely, as it shouldn't be needed for the app's deployment |
Override IHP's programs.vim.defaultEditor with mkForce false. NixOS 25.05 added assertion requiring vim.enable when defaultEditor is true. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@amitaibu Right, I simplified the solution based on this, it works as well. |
There was a problem hiding this comment.
Pull request overview
Updates NixOS production configuration and CI deploy scripting to avoid NixOS 25.05 vim assertions and provide clearer deployment failure reporting.
Changes:
- Force
programs.vim.defaultEditor = falsein the production NixOS host config to override the IHP module’s default and satisfy the NixOS 25.05 assertion. - Improve GitHub Actions deploy step failure handling by enabling strict shell behavior and emitting a GitHub Actions
::error::annotation on failure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Config/nix/hosts/production/configuration.nix |
Overrides programs.vim.defaultEditor to prevent the NixOS 25.05 assertion from breaking deployment. |
.github/workflows/test.yml |
Adds stricter shell settings and a clearer error annotation when deploy-to-nixos fails. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I think we should rather updates this one here: https://github.com/digitallyinduced/ihp/blob/master/NixSupport/nixosModules/appWithPostgres.nix#L23 because that's the actual source of vim here 👍 |
|
@copilot address #55 (comment) |
Before the config change,
deploy-to-nixosfailed with:NixOS 25.05 added this assertion. The IHP module sets
programs.vim.defaultEditor = true, so we override it withmkForce falseinstead of enabling vim (which isn't needed for deployment).