Merged
Conversation
this can speed up compile times when using e.g. esbuild for bundling
Member
Author
|
Quick idea: We could remove the hardcoded bootstrap-5.2.1 in the IHP repository with this feature. E.g. we could drop something like this into the ihp-boilerplate: |
Member
Author
|
Another cool use of this API: adding the |
Collaborator
|
This could also be used for building Tailwind? |
Member
Author
|
Yes, exactly. The first code example actually calls tailwind: So we'd only need to remove the esbuild stuff around it and it works for tailwind 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: App that has a
static/Frontenddirectory that contains an esbuild bundled JS app.Running
nix buildwill now produce an app with a static/Frontend directory. It will internally callnix build .#frontendas specified bystatic.extraDirs.Frontend = self.packages.${system}.frontend.With
static.makeBundling = falsewe can skip themake static/app.cssstep done typically by IHP. This can speed up deployment a bit when it's not used anyways.