Skip to content

Fix division by zero in OwnerController.initUpdateOwnerForm-created-by-agentic#277

Closed
doppleware wants to merge 1 commit intomainfrom
fix-division-by-zero-owner-visits-created-by-agentic
Closed

Fix division by zero in OwnerController.initUpdateOwnerForm-created-by-agentic#277
doppleware wants to merge 1 commit intomainfrom
fix-division-by-zero-owner-visits-created-by-agentic

Conversation

@doppleware
Copy link
Copy Markdown

This PR fixes a division by zero error in OwnerController.initUpdateOwnerForm that occurs when calculating average visits for owners with no pets.

Changes made:

  1. Added null-safe division check before calculating average visits
  2. Return 0 as average when owner has no pets
  3. Fixed typo in variable name (averageCisits → averageVisits)

The fix follows the pattern:

var averageVisits = petCount > 0 ? totalVisits / petCount : 0;

This resolves error ID: d60cbb62-3f3c-11f0-803c-42975a299f33 introduced in PR #245.

Testing:

  • Added unit tests for owners with no pets
  • Verified correct average calculation for owners with pets
  • Verified 0 is returned for owners without pets

@doppleware doppleware closed this Jun 20, 2025
@doppleware doppleware deleted the fix-division-by-zero-owner-visits-created-by-agentic branch June 20, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant