restore types package export#14
Merged
lahmatiy merged 1 commit intodiscoveryjs:masterfrom Oct 24, 2024
Merged
Conversation
Removed in discoveryjs@05c261f#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L31 Fixes typescript error > error TS7016: Could not find a declaration file for module '@discoveryjs/json-ext'. '.../node_modules/@discoveryjs/json-ext/src/index.js' implicitly has an 'any' type. > There are types at '.../node_modules/@discoveryjs/json-ext/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@discoveryjs/json-ext' library may need to update its package.json or typings.
Member
|
Thank you! |
Member
|
I remembered why I removed this line – the updated esbuild started giving a warning. |
Contributor
Author
|
makes sense. resolved - thanks! and yes good point to put the "types" key first.. it appears previous typescript version docs used to mandate it being first, although seemingly recent versions have been tolerating "types" in any position |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts the recent removal of the
"types"package export in 05c261f#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L31Fixes typescript error