RS Local texture parameters latency improvements#129
RS Local texture parameters latency improvements#129egorovaanastasiia wants to merge 2 commits intoRS3.0-UE5.3from
Conversation
…ndpoint, call it from render thread before. DSOF-30790
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
egorovaanastasiia
requested review from
elaineqiu-cmd,
ivaylo-disguise,
josharms-disguise and
pkevin-disguise
|
in the description, we have a case for old version of d3 + the new plugin. what about the new version of d3 + old plugin case? |
Sorry, mentioned it in the other PR but not here: newer d3 + old plugin would still work, just with no improvements for "Waiting in cache" |
| } | ||
| if (!GIsEditor) | ||
| { | ||
| FPlatformMisc::RequestExit(true); |
There was a problem hiding this comment.
I wonder if this will suffer from the same exit infinite loop issue as the one seen in the UE ghost process problem. Try this in an nDisplay session with 2 RXs.
There was a problem hiding this comment.
No, both RXs in this case kill the UE process. All good
| ENQUEUE_RENDER_COMMAND(RegisterTextureParams)([](FRHICommandListImmediate& RHICmdList) { | ||
| RenderStreamLink::instance().rs_registerTextureParams(); | ||
| }); | ||
| FlushRenderingCommands(); |
There was a problem hiding this comment.
I'm worried about the performance impact of synchronizing the GPU and CPU threads with the flush. If we really need the flush, please check performance is not impacted too much.
There was a problem hiding this comment.
You might be right. Seems like with a heavier scene with 9 TPs the fps of the streams dropped by 2-3 frames
| RenderStreamLink::RenderStreamLink() | ||
| { | ||
| loadExplicit(); | ||
| FString unused; |
There was a problem hiding this comment.
Unused ? Why do we need this ?
4 participants
DSOF-30790
Description:
Texture parameters for RSL were reported to have a high latency, around 5-9 frames.
This PR consists of d3 changes in https://github.com/disguise-one/d3/pull/5933 and plugin changes in this PR.
There are 2 main changes in plugin:
rs_registerTextureParams()API endpoint to read shared texture before using it. Must be called from the UE render thread.RenderStream::StartupModule()logic, so we cache the error, loadrs_logToD3and show the message in d3before closing UE.