Fix hello world, use inlined files instead of strings#1614
Merged
kubukoz merged 2 commits intodisneystreaming:series/0.18from Oct 23, 2024
Merged
Fix hello world, use inlined files instead of strings#1614kubukoz merged 2 commits intodisneystreaming:series/0.18from
kubukoz merged 2 commits intodisneystreaming:series/0.18from
Conversation
kubukoz
approved these changes
Oct 23, 2024
kubukoz
reviewed
Apr 1, 2025
Member
There was a problem hiding this comment.
oops, looks like we shouldn't have added this. It slipped under my radar (now Yarn complains that there's a package-lock whereas there should only be a yarn lockfile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The snippet on the landing page isn't actually valid Smithy because it used 2.0 features without specifying version, and because it doesn't have a namespace.
With these changes I can simply run the CLI on it.
Additionally, removed the multiline strings which were weird to edit, and instead used webpack's raw-loader to use actual files. Page looks the same