Add Makefile for building/testing/linting project#24
Merged
sendqueery merged 4 commits intodisneystreaming:developfrom Jul 14, 2020
Merged
Add Makefile for building/testing/linting project#24sendqueery merged 4 commits intodisneystreaming:developfrom
sendqueery merged 4 commits intodisneystreaming:developfrom
Conversation
JordanFaust
force-pushed
the
add-makefile
branch
2 times, most recently
from
525ae25 to
eb6aa9b
Compare
Adds a Makefile that provides a build, clean, test, and lint command. These commands are used for local development while goreleaser is still used for release the go artifacts/docker container. The goreleaser pipeline now leverages the make test command for running tests as a pre hook to the release pipeline
JordanFaust
force-pushed
the
add-makefile
branch
from
eb6aa9b to
b3dc1ac
Compare
added 3 commits
June 25, 2020 14:07
Splits build into an os agnostic build and introduces a docker build command that rebuilds the binary for linux before building the container
jschell12
reviewed
Jun 26, 2020
| #------------------------------------------------------------------------------ | ||
|
|
||
| SHELL := /bin/bash | ||
| PKG := github.com/disneystreaming/ssm-helpers |
Contributor
There was a problem hiding this comment.
supernitpick.
Do we want to format/align variables and their values?
ex:
SHELL := /bin/bash
PKG := github.com/disneystreaming/ssm-helpers
IMAGE := docker.pkg.github.com/disneystreaming/ssm-helpers/ssm
Contributor
Author
There was a problem hiding this comment.
If you can get this to align better please let me know. Tabs are absolutely horrible.
sendqueery
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Add Makefile for building/testing/linting project * Fix import lints * Add formatting as part of build command * Make build os agnostic Co-authored-by: jfaust <jordan.faust@disneystreaming.com>
sendqueery
pushed a commit
that referenced
this pull request
Sep 3, 2020
* Add Makefile for building/testing/linting project * Fix import lints * Add formatting as part of build command * Make build os agnostic Co-authored-by: jfaust <jordan.faust@disneystreaming.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Makefile that provides a build, clean, test, and lint command.
These commands are used for local development while goreleaser is still
used for release the go artifacts/docker container. The goreleaser
pipeline now leverages the make test command for running tests as a pre
hook to the release pipeline