Small flag rename, add ssm-session flag validation#35
Merged
sendqueery merged 2 commits intov1from Aug 13, 2020
Merged
Conversation
sendqueery
force-pushed
the
session-checking
branch
from
9ec1481 to
8067680
Compare
jschell12
reviewed
Aug 13, 2020
| return maxErrors, nil | ||
| } | ||
|
|
||
| func validateSessionFlags(cmd *cobra.Command, instanceList []string, filterList map[string]string) error { |
Contributor
There was a problem hiding this comment.
It's either this or just --instance would get priority and --filter would be ignored.
Collaborator
Author
There was a problem hiding this comment.
I'd prefer to be explicit about it (as we are with validateRunFlags) so that users have a clear understanding of how the flags work. The reason we're making it fail is because passing instance IDs as well as filters will cause the AWS API to throw an error, and I think we should reflect that here.
jschell12
approved these changes
Aug 13, 2020
sendqueery
added a commit
that referenced
this pull request
Sep 3, 2020
* Small flag rename, add ssm-session flag validation * Add test for validateSessionFlags()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just want to get these merged in before I do a PR for the bigger stuff to trim things down a bit. :)