Refactor of "session" and assorted related functions#39
Merged
sendqueery merged 16 commits intov1from Aug 25, 2020
Merged
Conversation
ncatelli
reviewed
Aug 25, 2020
ncatelli
left a comment
ncatelli
left a comment
There was a problem hiding this comment.
Initial run through and manual testing lgtm
| cmdutil.AddLimitFlag(cmd, 10, "Set a limit for the number of instance results returned per profile/region combination.") | ||
| cmdutil.AddTagFlag(cmd) | ||
| cmdutil.AddSessionNameFlag(cmd, "ssm-session") | ||
| addBaseFlags(cmd) |
jschell12
approved these changes
Aug 25, 2020
JordanFaust
approved these changes
Aug 25, 2020
sendqueery
added a commit
that referenced
this pull request
Sep 3, 2020
* Greatly reduce the number of rate-limited API calls we make * Move to use of paginated AWS functions to improve code readability * Update, improve, and add additional tests * Simplify EC2 tag retrieval * Improve performance of concurrent-safe methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goals: