Add GHCR as a goreleaser target alongside github packages#48
Merged
sendqueery merged 2 commits intodisneystreaming:developfrom Jun 18, 2021
ncatelli:add-ghcr-as-a-release-target
Merged
Add GHCR as a goreleaser target alongside github packages#48sendqueery merged 2 commits intodisneystreaming:developfrom ncatelli:add-ghcr-as-a-release-target
sendqueery merged 2 commits intodisneystreaming:developfrom
ncatelli:add-ghcr-as-a-release-target
Conversation
Author
|
GHCR is not currently enabled for this org. Blocked until we can get it enabled. |
Author
|
This has been enabled internally and should be good to merge. |
sendqueery
approved these changes
Jun 18, 2021
Collaborator
sendqueery
left a comment
sendqueery
left a comment
There was a problem hiding this comment.
LGTM. Thanks for knocking this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
This PR adds the Github Container Registry as an additional target for docker images. This is to:
Additional information is covered on the Migrating to ghcr link.
Other Changes
In addition to the above fixes, this PR includes a small change to remove an explicit shell setting in the devcontainer spec allowing users to pick their preferred shell for the terminal.