Add install directive to specify correct homebrew installed binary.#52
Merged
sendqueery merged 2 commits intodisneystreaming:developfrom Jul 23, 2021
ncatelli:bugfix/homebrew-release-install-incorrect-binary
Merged
Add install directive to specify correct homebrew installed binary.#52sendqueery merged 2 commits intodisneystreaming:developfrom ncatelli:bugfix/homebrew-release-install-incorrect-binary
sendqueery merged 2 commits intodisneystreaming:developfrom
ncatelli:bugfix/homebrew-release-install-incorrect-binary
Conversation
Author
|
Symlink is probably my preferred method of the 3 and I will probably modify this PR to reflect that unless there are any other opinions. This will also probably help us avoid a version bump for the breaking change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our releases pack the binary
ssminto each tar archive.https://github.com/disneystreaming/homebrew-tap/blob/master/Formula/ssm-helpers.rb#L28-L30
General
This PR fixes a bug where our homebrew releases currently are attempting to install a
ssm-helpersbinary from our released archive rather thanssm. As can be seen in https://github.com/disneystreaming/homebrew-tap/blob/master/Formula/ssm-helpers.rb#L28-L30This change WILL change the binary, but this is a change that brings it into consistency with all other deployments.
We can either,
ssm-helpersto the binaryssm-helpersconsistentlyI'm happy to modify this PR to any of the above options.
Other Changes