Fixes a bug in the instance id list copy#60
Merged
ncatelli merged 1 commit intodisneystreaming:developfrom Oct 27, 2021
ncatelli:bugfix/session-i-flag-failing-to-resolve
Merged
Fixes a bug in the instance id list copy#60ncatelli merged 1 commit intodisneystreaming:developfrom ncatelli:bugfix/session-i-flag-failing-to-resolve
ncatelli merged 1 commit intodisneystreaming:developfrom
ncatelli:bugfix/session-i-flag-failing-to-resolve
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
This PR fixes a bug reported directly by @ledor473 that caused sessions to fail to look up instances by id using the -i flag. This was caused by a bad use of
copycausing 0 instances to be copied from the array of user passed instance ids to an empty thread local slice.