Update minimal version to go 1.16#65
Merged
ncatelli merged 2 commits intodisneystreaming:developfrom May 24, 2022
ncatelli:update-minimal-version-to-go-1.16
Merged
Update minimal version to go 1.16#65ncatelli merged 2 commits intodisneystreaming:developfrom ncatelli:update-minimal-version-to-go-1.16
ncatelli merged 2 commits intodisneystreaming:developfrom
ncatelli:update-minimal-version-to-go-1.16
Conversation
zbintliff
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General
This PR bumps the minimum version of go to
1.16in both go mod and the build jobs to resolve an issue where some of our mac users are impacted by golang/go#49219.Testing
Prior to these changes:
After dep update, builds pass:
$> CGO_ENABLED=0 go build -o bin/ssm main.go go: downloading [github.com/AlecAivazis/survey/v2](http://github.com/AlecAivazis/survey/v2) v2.3.4 go: downloading [github.com/aws/aws-sdk-go](http://github.com/aws/aws-sdk-go) v1.44.19 go: downloading [github.com/sirupsen/logrus](http://github.com/sirupsen/logrus) v1.8.1 go: downloading [github.com/spf13/cobra](http://github.com/spf13/cobra) v1.4.0 go: downloading [golang.org/x/sys](http://golang.org/x/sys) v0.0.0-20220520151302-bc2c85ada10a go: downloading [github.com/spf13/pflag](http://github.com/spf13/pflag) v1.0.5 go: downloading [golang.org/x/term](http://golang.org/x/term) v0.0.0-20220411215600-e5f449aeb171 go: downloading [github.com/mattn/go-colorable](http://github.com/mattn/go-colorable) v0.1.12 go: downloading [github.com/mattn/go-isatty](http://github.com/mattn/go-isatty) v0.0.14 go: downloading [github.com/jmespath/go-jmespath](http://github.com/jmespath/go-jmespath) v0.4.0Issues
relates to #63
caused by golang/go#49219
Other changes