Only load django_redis when Django version is lower than 4#446
Closed
mounirmesselmeni wants to merge 1 commit intodjango-commons:masterfrom
Closed
Only load django_redis when Django version is lower than 4#446mounirmesselmeni wants to merge 1 commit intodjango-commons:masterfrom
mounirmesselmeni wants to merge 1 commit intodjango-commons:masterfrom
Conversation
Avoid forcing users to install django_redis just to have this working
Member
|
It seems #449 supersedes this PR. The tool doesn't support Django < 4 anymore and there is no need to handle that condition anymore. |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid forcing users to install django_redis just to have this working.
Support for Django 4+ was added but the library django_redis is always loaded.