fix: catch AttributeError in config check for non-dict WEBPACK_LOADER#433
Open
saschabuehrle wants to merge 1 commit intodjango-webpack:masterfrom
Open
fix: catch AttributeError in config check for non-dict WEBPACK_LOADER#433saschabuehrle wants to merge 1 commit intodjango-webpack:masterfrom
saschabuehrle wants to merge 1 commit intodjango-webpack:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#427 — The
webpack_cfg_checksystem check crashes withAttributeError: 'list' object has no attribute 'values'whenWEBPACK_LOADERis set to a non-dict value (e.g. a list orNone).Fix
Added
AttributeErrorto the existingexcept TypeErrorclause inwebpack_cfg_check(). WhenWEBPACK_LOADERis a list, string,None, or any other non-dict type, calling.values()raisesAttributeErrorinstead ofTypeError. By catching both, the function now correctly returns theBAD_CONFIG_ERRORdiagnostic instead of crashing.Testing
Verified that:
BAD_CONFIG_ERRORcheck result instead of crashingTypeErrorpath (dicts with non-dict values) still triggers correctlyHappy to address any feedback.
Greetings, saschabuehrle