Multiple target urls get triggered twice

[Tyarel8]

Describe the bug
After trying a custom bang with multiple target urls, every url that is not the first one opens two tabs. If I have urls 1, 2 and 3; it will open like: 1, 2, 3, 2, 3. If I have urls 1 and 2; it will open: 1, 2, 2.

Desktop (please complete the following information):

• OS: Windows
• Browser: Zen
• Version: 1.17.4b

[dmlls]

Hi @Tyarel8, thanks for reporting. Unfortunately, I cannot reproduce this behavior. Could you please create a backup of your bangs, open the generated .json, and check if the targets are duplicated for the specific bang causing this problem?

[Tyarel8]

    {
      "name": "Game keys",
      "bang": "gkeys",
      "targets": [
        {
          "url": "https://www.loaded.com/#q={{{s}}}",
          "baseUrl": "https://www.loaded.com/",
          "urlEncodeQuery": false
        },
        {
          "url": "https://www.instant-gaming.com/en/search/?query={{{s}}}",
          "baseUrl": "https://www.instant-gaming.com/",
          "urlEncodeQuery": false
        }
      ]
    }

It's not duplicated in the json. I have also tried in my laptop (same browser) and have the same issue. Also tried plain firefox (145.0b9) instead of zen, and the issue persists. Also if I change the order of the bangs, the second one still is the one that opens twice.

[dmlls]

Mmh, I tried setting the exact same bang and things still work as expected on Zen and Firefox (both desktop and mobile). I'm running Linux, I wonder if this might be Windows-related? (can't thing why it would though) I don't know if you happen to run Android and could test it there as well?

Also another question, did you set this bang manually or through a backup? And does the problem also appear when you create a new bang with multiple targets?

[Tyarel8]

I tried in android and it works fine, so it might be some windows thing. I created the bang through the gui, and creating another one also has the issue.

[dmlls]

Interesting... To help further narrow down the problem, if you create a backup, reinstall Yang, and restore from the backup, the issue still persists? And if you have any Chromium-based browser installed, could you also try there and see if you get the same behavior? Thanks!

[Tyarel8]

I tried in edge and there was no problem. Tried removing yang, reinstalling it and loading the backup, and the issue persists.

[dmlls]

I don't have access to any Windows machine, but I installed Windows 10 on a virtual machine and, unfortunately, I still cannot reproduce it.

The code is very straightforward, we use browser.tabs.update for the first URL target, and browser.tabs.create for the subsequent targets. I therefore assume the problem must lie in the browser.tabs.create function, but I haven't found any relevant bug report related to this.

I'd say let's keep this issue open for now and see if anyone else experiences this problem.

[Tyarel8]

I have tried debugging the extension myself, and it seems the whole browser.webRequest.onBeforeRequest.addListener runs twice with two different urls

Object { url: URL }
​
url: URL { href: "https://duckduckgo.com/?t=ffab&q=%21gkeys", origin: "https://duckduckgo.com", protocol: "https:", … }
​
<prototype>: Object { … }
background.js:74:17

Object { url: URL }
​
url: URL { href: "https://duckduckgo.com/?t=ffab&q=%21gkeys&atb=v467-1", origin: "https://duckduckgo.com", protocol: "https:", … }
​
<prototype>: Object { … }
background.js:74:17

It seems like duckduckgo is re-sending the url with atb=v467-1 as an url parameter, and that is causing the opening of the two tabs. The first target url is also being fired twice but since it only changes the current tab, it doesn't do anything.

[dmlls]

Okay, now that makes sense! I should add the search engine to the bug template, since this information is relevant (I couldn't reproduce because I'm not using ddg). I'll publish a release as soon as possible with a fix, thanks!

[dmlls]

Fixed in the new release. Thanks!