fails sometimes

[Tyarel8]

Describe the bug
Sometimes a bang doesn't work. I have debugged it and it seems that duckduckgo fires a lot of request and all of them end up getting filtered.

Here is an example using the !t3 bang, it first fails and the second time I try it works normal.
Fails:

Object { position: "pre-filter", url: "https://duckduckgo.com/?t=ffab&q=%21t3" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/?t=ffab&q=%21t3&atb=v467-1" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/s.724eebdd5d70e95715ff.css" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/r.8e00548ad2c70884f048.css" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpl.main.7e0975961e269fd1e827.css" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/font/DuckSansProduct-Regular.woff2" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/font/DuckSansProduct-Medium.woff2" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/font/DuckSansProduct-Bold.woff2" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/b.cb06044def27699438cf.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/lib/l.32113981e35aa54fc221.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/locale/en_GB.7b096e50ddb02c55510aa3c0f810855b.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/util/u.fbbce12d2bc22280fd4b.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpmv.0e483cbadf034dc623a9.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.main.347836f617401d940187.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/d.da46c1666da2017aae0e.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/g.5ef83b725d7428491e99.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/assets/logo_header.v109.svg" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/t.js?q=!t3&l=wt-wt&s=0&ct=ES&bing_market=en-US&p_ent=&ex=-1&dp=0K64c8WtBdhIZnlst3Z1hzzqRK2L0oZgprwW3atJDbSxVQRBkyn7UWeGwdqAtMGc81cjl0MLXMl2LnkvVipWAFtFQ1LmZElaL1pTfSoZ4w-bNJhB6FML_6HR1b2lxxtR.HaBZPG0G6ulgnvDI_4z1Vg&perf_id=abde9250335464fa&parent_perf_id=e5a3b8a3d781a31b&perf_sampled=0&host_region=eun&dfrsp=1&aps=0&biaexp=b&litexp=b&msvrtexp=b&searchbarexp=b&tadateexp=a&weatherexp=b" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/post3.html" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/s.862a716c937860ab008e.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/react-assets/fe21b530ba74e4553643.svg" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/react-assets/51ff8f5f877025448b4a.svg" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/react-assets/09ab90ee860bbc73c1ea.svg" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/p.f5b58579149e7488209f.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/assets/icons/meta/DDG-iOS-icon_152x152.png?v=2" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/favicon.ico" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.duckassist-ia.b0bffb0beb4b3c755157.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.duckassist-ia.9377c2bf63cfaa66adde.css" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.1619.36c7464fcbf3bdd269a2.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.6015.cfa5f69a274650cb5207.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.9814.0edfef7a69338d1a5867.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/dist/wpm.duckassist-ia.b0bffb0beb4b3c755157.js" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/assets/icons/related/loupe-grey.svg" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/font/DuckSansDisplay-Regular.woff2" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/font/DuckSansDisplay-Bold.woff2" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/assets/icons/favicons/wikipedia.white.2x.png" }
background.js:44:13
Object { position: "pre-filter", url: "https://duckduckgo.com/y.js?ifu=%7B3%7Dappid%3D055AAD1BA669BEB8B048128DC89A107C678B527B%26rguid%3D1e5213a2ff89477182770a56d401e3f1&iurl=%7B2%7DIG%3D2D98F497281E40A19A599A3958D426CB%26CID%3D121EF3EDF0B669CC006BE573F1C9686B%26Type%3DEvent.CPT%26DATA%3D0&impr=1m%3A12%7C5m%3A13%3B14&rvf=1%2C5&ads-hidden=1&t=ffab&adUnitIndex=9&aba=0" }
background.js:44:13

Succeeds

Object { position: "pre-filter", url: "https://duckduckgo.com/?q=%21t3&t=ffab&atb=v467-1&we_feature_name=requery&we_started_at=14-05-50_051" }
background.js:44:13
Object { position: "post-filter", url: "https://duckduckgo.com/?q=%21t3&t=ffab&atb=v467-1&we_feature_name=requery&we_started_at=14-05-50_051" }
background.js:150:13

Desktop (please complete the following information if possible):

• Yang version: 2.0.0
• Search engine: duckduckgo
• OS: Windows
• Browser: Zen
• Browser Version: 1.17.6b

[dmlls]

I've published v2.0.2 with an attempt to fix this. Since this behavior only happens sometimes, it is kind of hard to debug. Feel free to reopen the issue if the problem persists.

[Tyarel8]

It seems the bug is still present in 2.0.2 (I don't have permission to reopen the issue). Happens consistently when you wait a while (only a few minutes) and then use it again, the first bang you try fails while the following ones have no issue

[Tyarel8]

Looking at the code, could it be that after some time firefox kills the background.js script, and then when you do the first bang, it runs it again and this line

yang/background.js

Line 39 in 6b3439a

let lastTriggerTime = new Date();

causes the bang to fail since it thinks that some bang already run before?

yang/background.js

Lines 112 to 115 in 6b3439a

	// Ensure we only trigger the bang once.
	if (currentTime - lastTriggerTime < 500) {
	return null;
	}

That also could explain why it didn't error nearly as often when debugging, a message in the console says Background event page was not terminated on idle because a DevTools toolbox is attached to the extension.

[dmlls]

@Tyarel8 yes, you are right!

Whenever the background script was terminated (this is done automatically by the browser), the counter was being initialized with the current time, getting to the second code snippet before those 500 ms had passed, and therefore skipping the first (and legitimate) request.

The release is already published, hope this one is the one! ;)

[Tyarel8]

Thanks for bearing with me for all this back and forth 😅, but while this issue is solved, it is triggering every url after the first twice again (#61). That's why I added this commit 4233665 in the pull request (#66), when I tried with this change it seemed to work.

[dmlls]

Oh no :')

Your change is still included, I just moved it down so that lastTriggerTime is only updated when a bang is successfully triggered. Can you try with the patch in the branch v2.0.4?