Skip to content

Conversation

@Starefossen
Copy link
Contributor

Update node to v4.2.1.

Changeset: nodejs/docker-node@184653e...04df868

We have two significant regressions with v4.2.0. Fixes have landed in master and v4.x. These are significant issues that affect native modules and anything using timers.

[nodejs/node@b3cbd13340] - buffer: fix assertion error in WeakCallback (Fedor Indutny) nodejs/node#3329
[nodejs/node@c245a199a7] - lib: fix undefined timeout regression (Ryan Graham) nodejs/node#3331

Related: nodejs/docker-node#56 nodejs/node#3337
Signed-off-by: Hans Kristian Flaatten [email protected]

PR-URL: docker-library#1120

Related: nodejs/docker-node#56 nodejs/node#3337

Signed-off-by: Hans Kristian Flaatten <[email protected]>
@tianon
Copy link
Member

tianon commented Oct 13, 2015

LGTM

@yosifkit
Copy link
Member

LGTM, Build test of #1120; ac72b82 (node):

$ url="https://raw.githubusercontent.com/docker-library/official-images/ac72b821066329aeeef9393391b401d5703380b8/library/node"
$ bashbrew build "$url"
Fetching node (git://github.com/nodejs/docker-node) ...
Processing node:0.10.40 ...
Processing node:0.10 ...
Processing node:0.10.40-onbuild ...
Processing node:0.10-onbuild ...
Processing node:0.10.40-slim ...
Processing node:0.10-slim ...
Processing node:0.10.40-wheezy ...
Processing node:0.10-wheezy ...
Processing node:0.12.7 ...
Processing node:0.12 ...
Processing node:0 ...
Processing node:0.12.7-onbuild ...
Processing node:0.12-onbuild ...
Processing node:0-onbuild ...
Processing node:0.12.7-slim ...
Processing node:0.12-slim ...
Processing node:0-slim ...
Processing node:0.12.7-wheezy ...
Processing node:0.12-wheezy ...
Processing node:0-wheezy ...
Processing node:4.2.1 ...
Processing node:4.2 ...
Processing node:4 ...
Processing node:latest ...
Processing node:4.2.1-onbuild ...
Processing node:4.2-onbuild ...
Processing node:4-onbuild ...
Processing node:onbuild ...
Processing node:4.2.1-slim ...
Processing node:4.2-slim ...
Processing node:4-slim ...
Processing node:slim ...
Processing node:4.2.1-wheezy ...
Processing node:4.2-wheezy ...
Processing node:4-wheezy ...
Processing node:wheezy ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing node:0.10.40
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.10.40-onbuild
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.10.40-slim
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.10.40-wheezy
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.12.7
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.12.7-onbuild
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.12.7-slim
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:0.12.7-wheezy
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:4.2.1
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:4.2.1-onbuild
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:4.2.1-slim
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed
testing node:4.2.1-wheezy
    'utc' [1/5]...passed
    'cve-2014--shellshock' [2/5]...passed
    'no-hard-coded-passwords' [3/5]...passed
    'override-cmd' [4/5]...passed
    'node-hello-world' [5/5]...passed

yosifkit added a commit that referenced this pull request Oct 13, 2015
@yosifkit yosifkit merged commit 6c86bc5 into docker-library:master Oct 13, 2015
@Starefossen
Copy link
Contributor Author

Thanks for the quick merge of this guys! 😅🚀

@yosifkit
Copy link
Member

I figured a new release on the next day was fairly important and you guys make it so easy to review 😃👍.

RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants