docs: Change use of "Name" to "Path" in dockerfile option information

[matthewfeickert]

Hi. Thanks very much for making this GitHub Action!

I'd like to suggest that in the dockerfile option the text

Name of the Dockerfile

be changed to

Path to the Dockerfile relative to path.

When I first read the docs I got confused by the use of "path" and "name" (instead of "context" and "path") and for a directory that structure that is structured with

$ tree
.
├── other_files_needed_for_build
├── docker
│   └── Dockerfile

attempted to use

    - name: Build and Publish to Registry
      uses: docker/build-push-action@v1
      with:
        username: ${{ secrets.DOCKER_USERNAME }}
        password: ${{ secrets.DOCKER_PASSWORD }}
        repository: org/repo-name
        path: docker
        dockerfile: Dockerfile

instead of the following (correct)

    - name: Build and Publish to Registry
      uses: docker/build-push-action@v1
      with:
        username: ${{ secrets.DOCKER_USERNAME }}
        password: ${{ secrets.DOCKER_PASSWORD }}
        repository: org/repo-name
        dockerfile: docker/Dockerfile

I think the use of "path" would be more clear than "name". If you agree with me I have a branch with this change on my fork that I can open a PR here on (though telling me to do so might involve more typing).

[zappy-shu]

Hi @matthewfeickert. Thanks for your feedback.

The README is wrong, the dockerfile path is not changed by the path input. I will make a correction if the dockerfile input is set.

The path input is relate to the PATH argument in the docker build CLI command while dockerfile relates to the --file option.

Setting the path changes the context as described here: https://docs.docker.com/engine/reference/commandline/build/

[matthewfeickert]

Thanks very much, @zappy-shu. I took a look at PR #16 and that seems to perfectly clarify things.