Use fips compliant go compiler#35
Merged
seemethere merged 1 commit intodocker:masterfrom Aug 16, 2018
corbin-coleman:fips-builds
Merged
Use fips compliant go compiler#35seemethere merged 1 commit intodocker:masterfrom corbin-coleman:fips-builds
seemethere merged 1 commit intodocker:masterfrom
corbin-coleman:fips-builds
Conversation
Switches x86 images and windows builds to use our FIPS compliant go compiler images. Signed-off-by: corbin-coleman <corbin.coleman@docker.com>
corbin-coleman
changed the title
jose-bigio
reviewed
Aug 16, 2018
| @@ -0,0 +1,15 @@ | |||
| # escape=` | |||
Contributor
There was a problem hiding this comment.
Probably denotes a different escape character for the Dockerfile parser since \ is a valid character on windows and is usually the default escape character
Contributor
Author
There was a problem hiding this comment.
It's not that that's the escape character for Powershell. But it's mostly there because this is just a copy of the Dockerfile for this image https://hub.docker.com/r/johnstep/build-containerd/ <- There's a link to the Dockerfile on that page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes changes in deb.dockerfile and rpm.dockerfile to build containerd with a fips compliant compiler.
Signed-off-by: corbin-coleman corbin.coleman@docker.com