Fix FromForm without WithOpenApi schemas#3133
Fix FromForm without WithOpenApi schemas#3133martincostello merged 12 commits intodomaindrivendev:masterfrom
Conversation
… extension method
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3133 +/- ##
==========================================
+ Coverage 91.44% 91.55% +0.10%
==========================================
Files 76 76
Lines 3121 3125 +4
Branches 520 526 +6
==========================================
+ Hits 2854 2861 +7
+ Misses 267 264 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…hemas similar between MinimalApi and Controllers
|
Thanks - will merge this after #3007. |
…ameters(The XML filter was removing the description)
|
We may need to create an issue to check the order of filters to avoid this behaviour but I applied here.. I can remove it if you like and address it on other PR.. But I did not know why the Description did not show up. First filter wins? |
Probably. I did similar things in my new OpenAPI extensions NuGet package to not overwrite things in the OpenAPI document if they already had a value. |
|
@jgarciadelanoceda I am writing because this commit removed enums from FromForm. |
|
Please create a new issue for this regression with a fully reproducible example, rather than commenting on a complete PR. The change won't be reverted, we'll just fix-forward. |
Fixes #3126.
Also I have found that there was an error for WithOpenApi for FromFormParameters that are enums