Skip to content

Humanize multiline para tag#3234

Merged
martincostello merged 16 commits intodomaindrivendev:masterfrom
EvgeniyZ:humanize-multiline-para-tag
Jan 29, 2025
Merged

Humanize multiline para tag#3234
martincostello merged 16 commits intodomaindrivendev:masterfrom
EvgeniyZ:humanize-multiline-para-tag

Conversation

@EvgeniyZ
Copy link
Copy Markdown
Contributor

@EvgeniyZ EvgeniyZ commented Jan 25, 2025

The issue or feature being addressed

Fixes #3009

Details on the issue fix or feature implementation

Swagger.ui (or Redoc, I'm not sure) are displaying \r\n as <pre> tag.

PR changes making sure that text is trimmed and all line breaks are ignored

Swagger.ui (or Redoc, I'm not sure) are displaying '\r\n   ' as <pre> tag.
PR changes making sure that multi-line <para> text is trimmed and all line breaks within the text
are ignored
@EvgeniyZ EvgeniyZ closed this Jan 25, 2025
@EvgeniyZ EvgeniyZ reopened this Jan 25, 2025
Comment thread test/WebSites/Basic/Controllers/CrudActionsController.cs
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.60%. Comparing base (0ecfee4) to head (58cf6cb).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3234      +/-   ##
==========================================
+ Coverage   83.58%   83.60%   +0.02%     
==========================================
  Files          76       76              
  Lines        3161     3165       +4     
  Branches      536      536              
==========================================
+ Hits         2642     2646       +4     
  Misses        519      519              
Flag Coverage Δ
Linux 83.60% <100.00%> (+0.02%) ⬆️
Windows 83.60% <100.00%> (+0.02%) ⬆️
macOS 83.60% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/Swashbuckle.AspNetCore.SwaggerGen/XmlComments/XmlCommentsTextHelper.cs Outdated
Comment thread test/Swashbuckle.AspNetCore.IntegrationTests/SwaggerVerifyIntegrationTest.cs Outdated
@martincostello martincostello added this to the v7.2.1 milestone Jan 29, 2025
@martincostello martincostello merged commit 5ecbb3b into domaindrivendev:master Jan 29, 2025
This was referenced Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Multi-line paragraphs render as pre code html tag pair

3 participants