Update checkout and upload-artifact actions versions

[Akaame]

No description provided.

[jozefizso]

It is not apparent from the build checks, but these changes are failing the workflow: https://github.com/dorny/test-reporter/actions/runs/8596798196

[Akaame]

@jozefizso interesting, I do not think it is related to my changeset actually. Am I the first outside contributor who had auth problems for the download artifact action in this pipeline?

Edit: looking at the history it seems that I am the only one with the problem. I will create a minimal documentation change instead to see if the problem is with my changeset or some sort of weird auth issue.

[Akaame]

#420 created this and just realized the CI action ignores the *.md.

[cclauss]

Related to:

• Bump actions/upload-artifact from 3 to 4 #335
• README.md: Update GitHub Actions #404

I confirm this problem. I bet that if you revert these changes then things will work again.

-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4

[abelbraaksma]

Related: #343

TLDR: artifacts@v4 is NOT compatible with artifacts@v3 and may lead to auth issues, among others. See https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

[Akaame]

@jozefizso I added a hail-mary fix attempt for the solution after diving into @abelbraaksma has provided and reading this Reddit comment. IDK if this is the correct direction but I think we might as well give it a try.

TLDR: providing Authorization header to the Azure Blob Storage API was superfluous and had to be removed in the case above.

[Akaame]

Would it be possible for us to give the proposed solution a try?