Skip to content

Add application/*+json to supported media types#6

Merged
dotarj merged 1 commit intodotarj:masterfrom
aidanjryan:add-wildcard-mediatype
Jan 14, 2019
Merged

Add application/*+json to supported media types#6
dotarj merged 1 commit intodotarj:masterfrom
aidanjryan:add-wildcard-mediatype

Conversation

@aidanjryan
Copy link
Copy Markdown
Contributor

@aidanjryan aidanjryan commented Jan 10, 2019

Matches the default of the stock JSON formatter.
Fixes an issue with the newly-added ProblemDetails behavior that wants to use media type application/problem+json (details here).

Matches the default of the stock JSON formatter
Fixes an issue with the newly-added ProblemDetails behavior that
wants to use media type `application/problem+json`
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 10, 2019

Codecov Report

Merging #6 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #6      +/-   ##
=========================================
+ Coverage   67.89%   68.1%   +0.21%     
=========================================
  Files          15      15              
  Lines         299     301       +2     
=========================================
+ Hits          203     205       +2     
  Misses         96      96
Impacted Files Coverage Δ
....Formatters.Json/Internal/MediaTypeHeaderValues.cs 100% <100%> (ø) ⬆️
....Mvc.Formatters.Json/PartialJsonOutputFormatter.cs 89.79% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b06a51...be188e4. Read the comment docs.

@aidanjryan aidanjryan changed the title Add application/*+json to supported media types Add application/*+json to supported media types Jan 11, 2019
@dotarj
Copy link
Copy Markdown
Owner

dotarj commented Jan 14, 2019

Hi @aidanjryan, thanks for the PR. I'll merge it and let you know when it will be released (probably after #1 has been merged).

@dotarj dotarj merged commit b37da64 into dotarj:master Jan 14, 2019
@aidanjryan
Copy link
Copy Markdown
Contributor Author

Cool, thanks!

@dotarj
Copy link
Copy Markdown
Owner

dotarj commented Jan 25, 2019

Hi @aidanjryan, this feature is now available in version 5.0.0.

@aidanjryan
Copy link
Copy Markdown
Contributor Author

Super, thanks for this!!

@aidanjryan aidanjryan deleted the add-wildcard-mediatype branch January 25, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants