adjust defaultBenchmarkDotNetVersion on build#1879
Merged
AndreyAkinshin merged 6 commits intodotnet:masterfrom Jul 4, 2023
Merged
adjust defaultBenchmarkDotNetVersion on build#1879AndreyAkinshin merged 6 commits intodotnet:masterfrom
AndreyAkinshin merged 6 commits intodotnet:masterfrom
Conversation
43cdcbf to
5ec4deb
Compare
Merged
AndreyAkinshin
requested changes
Jul 3, 2023
Member
AndreyAkinshin
left a comment
There was a problem hiding this comment.
Thanks for the PR (and sorry for the late review). In general, I like this approach, we can try to use it. Once the review comments are resolved, I will merge this PR.
| InputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json" | ||
| OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json" | ||
| MatchExpression='("defaultValue": )"([\d+\.?]+)"' | ||
| ReplacementText='${1}"$(Major).$(Minor).$(Revision)"' /> |
Member
There was a problem hiding this comment.
With the recent changes, we should use $(VersionPrefix) instead of $(Major).$(Minor).$(Revision).
| OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json" | ||
| MatchExpression='("defaultValue": )"([\d+\.?]+)"' | ||
| ReplacementText='${1}"$(Major).$(Minor).$(Revision)"' /> | ||
| <PropertyGroup> |
Member
There was a problem hiding this comment.
It seems that we don't actually need this PropertyGroup: all the arguments are defined in attributes of ReplaceFileText.
Contributor
Author
Contributor
Author
disregard this. It will not work due to dotnet/msbuild#5737 |
AndreyAkinshin
approved these changes
Jul 4, 2023
Member
|
@askazakov thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Some automatization to reconcile BenchmarkDotNet version with default version in template
If it's good enough I will fix templates for VB and F# also. If not just close PR