Improve session message injection#2117
Merged
chkr1011 merged 11 commits intodotnet:masterfrom Jan 2, 2025
Merged
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
AntonSmolkov
force-pushed
the
improve_session_message_injection
branch
from
8d5092d to
f96c10c
Compare
chkr1011
reviewed
Dec 2, 2024
chkr1011
requested changes
Dec 2, 2024
Collaborator
chkr1011
left a comment
chkr1011
left a comment
There was a problem hiding this comment.
Nice feature! But I recommend changing the public API a bit.
AntonSmolkov
force-pushed
the
improve_session_message_injection
branch
from
1b4cb4c to
2b1c143
Compare
AntonSmolkov
force-pushed
the
improve_session_message_injection
branch
from
841fa67 to
026029c
Compare
chkr1011
reviewed
Dec 3, 2024
chkr1011
reviewed
Dec 3, 2024
chkr1011
requested changes
Dec 3, 2024
Collaborator
chkr1011
left a comment
chkr1011
left a comment
There was a problem hiding this comment.
Just a few minor improvements.
Contributor
Author
|
@chkr1011 Thanks! The CI-workflow is not approved yet. It this intentional? |
Contributor
Author
|
@chkr1011 Sorry to bother you again, but the CI has failed on the "sign nugets step". :)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I'm trying to build a scalable, persistent MQTT server around RabbitMQ, using the MQTTNet server as a frontend.
While doing this, I found that there is currently no proper way to correlate injected QoS 1 messages with the packets received by the
ClientAcknowledgedPublishPacketAsyncevent. So, there is no way for me to pass the PUBACK further to RabbitMQ's message acknowledgment.Additionally, I noticed that
DeliverApplicationMessageAsync()method may hang indefinitely whenMqttPendingMessagesOverflowStrategy.DropNewMessageis used, because in the case of an output buffer overflow, thepacketBusItembeing awaited is dropped from the queue without the Task'sResultorExceptionbeing set.So, in this PR:
MqttPublishPacketas a result of message injection methods, to be able to correlate them by packet id later.DeliverApplicationMessageAsync()method.Thanks for the great project, btw!