Conversation
|
LGTM, I think you forgot to remove some more lines from the .nuspec file. |
|
Looks like this file can be deleted now:
|
|
It can. Almost everything beneath netcore/src/Common/System can join it, as can everything beneath netcore/src/Common/Interop/Unix, and quite a few files from netcore/src/Common/Interop/Windows. It'll also close #303 by default. |
benrr101
left a comment
There was a problem hiding this comment.
While this is definitely a minimal set of changes required for removing net6 support, there will be a lot of code removal required as well. If you can create an item in ado for that (and optionally assign to me), that'd be great. Any opportunity to remove derelect code is appreciated!
|
Azure Pipelines successfully started running 2 pipeline(s). |
| - name: netcoreVersionTestUtils | ||
| displayName: 'Netcore Version for Test Utilities' | ||
| type: object | ||
| default: net8.0 |
There was a problem hiding this comment.
This version is set here, but passed down through to the test util project compilation. Trying to keep this at the highest level possible so that it's easy to bump in the future without digging down in the individual jobs.
This PR includes the minimum necessary to drop net6 support.
I have two follow up PRs planned: