Cleanup | Merge SqlDataRecord and remove context connection remnants#3454
Merged
cheenamalhotra merged 7 commits intodotnet:mainfrom Jul 10, 2025
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
previously approved these changes
Jun 30, 2025
Contributor
benrr101
left a comment
benrr101
left a comment
There was a problem hiding this comment.
We do so 🫡
(one small request, but overall it's great)
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SqlDataRecord.cs
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3454 +/- ##
==========================================
- Coverage 64.55% 58.82% -5.73%
==========================================
Files 281 271 -10
Lines 62519 61984 -535
==========================================
- Hits 40358 36464 -3894
- Misses 22161 25520 +3359
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
previously approved these changes
Jul 2, 2025
samsharma2700
requested changes
Jul 3, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SqlDataRecord.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Server/SqlDataRecord.cs
Outdated
Show resolved
Hide resolved
Exit early if we have no fields to set. Clarify comment.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
approved these changes
Jul 4, 2025
benrr101
approved these changes
Jul 8, 2025
samsharma2700
approved these changes
Jul 9, 2025
This was referenced Mar 17, 2026
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This picks up where #3438 left off. With
SmiEventSink_Defaultremoved, almost all of the code in SqlDataRecord.netfx.cs and SqlDataRecord.netcore.cs is identical and can be removed. We do so.The
SmiRecordBufferclass is also removed, since this isn't doing anything meaningful. I'm not pleased with the overall type hierarchy here, but I want to think through the consequences of changing them in the wider context of ValueUtilsSmi.With that work done, we just remove the now-unused resource strings and exception methods from SqlUtil, AdapterUtil and the string resources. There are other unused strings and exception methods here, for anyone interested in picking up a bulky commit.
Closes #2838.
Issues
Follows #3438.
Resolves #2838.
Contributes to #1261.
Testing
Local unit tests for SqlDataRecord pass.