[6.1] Add CodeQL suppression for DefaultAzureCredential and fix macOS CI failures#3550
Merged
cheenamalhotra merged 1 commit intorelease/6.1from Aug 11, 2025
Merged
Conversation
…3542) * Task 37261: [S360] [SM05137] DefaultAzureCredential use in Production - Adjusted CodeQL suppression to meet the strict requirements of where it may appear relative to the flagged code. * Task 37261: [S360] [SM05137] DefaultAzureCredential use in Production - Adding catch for macOS socket error to log and ignore.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ports changes from PR #3542 to the 6.1 branch, focusing on CodeQL suppression compliance and macOS CI stability. The changes address static analysis requirements and handle platform-specific socket errors.
- Added proper CodeQL suppression with detailed justification for DefaultAzureCredential instantiation
- Enhanced error handling for socket timeout operations on macOS with logging
- Improved code structure by extracting constant and adding exception handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ActiveDirectoryAuthenticationProvider.cs | Added CodeQL suppression with justification and restructured DefaultAzureCredential instantiation |
| SniTcpHandle.netcore.cs | Added try-catch block for socket timeout reset with macOS-specific error handling and logging |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ManagedSni/SniTcpHandle.netcore.cs
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3550 +/- ##
================================================
+ Coverage 66.03% 90.82% +24.79%
================================================
Files 281 6 -275
Lines 62401 316 -62085
================================================
- Hits 41205 287 -40918
+ Misses 21196 29 -21167
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mdaigle
approved these changes
Aug 8, 2025
cheenamalhotra
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #3542.