Skip to content

Introduce Logging package and rework official pipelines#3967

Merged
paulmedynski merged 64 commits intomainfrom
dev/cheena/logging-package
Feb 24, 2026
Merged

Introduce Logging package and rework official pipelines#3967
paulmedynski merged 64 commits intomainfrom
dev/cheena/logging-package

Conversation

@cheenamalhotra
Copy link
Member

Summary

Moves the ETW SqlClientEventSource tracing infrastructure (~1,180 lines) from the core driver into a new Microsoft.Data.SqlClient.Extensions.Logging (netstandard2.0) NuGet package. This enables independent versioning and shared use across SqlClient and the AKV provider (which had its own AKVEventSource, now deleted).

Key Changes

Area What Changed
New package Microsoft.Data.SqlClient.Extensions.Logging — contains SqlClientEventSource, SqlClientMetrics, SqlClientEventScope, and scope types
Core driver SqlClientEventSource.cs reduced to a ~43-line SqlClientDiagnostics bridge; 28 source files updated from TryEventScope/TrySNIEventScopeSqlClientEventScope
AKV provider Deleted AKVEventSource.cs; AKV now uses the shared SqlClientEventSource.Log from the Logging package
Build build.proj gains Logging targets; nuspec files add Logging dependency across all TFMs
Pipelines Consolidated into unified OneBranch official/non-official pipelines with selective build params, approval service, ESRP signing for Logging, reusable publish job with dry-run; deleted 9 standalone pipeline/variable files
Docs Added PackageReadme.md for all 6 packages; new OneBranch pipeline design spec (522 lines); updated AGENTS.md

Checklist

  • No breaking changes — logging behavior preserved via the extracted package as a dependency

@github-project-automation github-project-automation bot moved this from In progress to Done in SqlClient Board Feb 24, 2026
This was referenced Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. Public API 🆕 Issues/PRs that introduce new APIs to the driver.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants