Merge | Not Supported Binaries / Test Targets#3997
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes two main changes: (1) adds test targets to build2.proj with detailed parameter documentation for running MDS tests via MSBuild, and (2) creates a new dedicated project (notsupported/) to generate "Not Supported" assemblies from the common MDS ref project using GenAPI, replacing the previous approach that was embedded in the netcore/netfx projects. Additional changes include strong-name signing for ref binaries, updated output paths for ref assemblies, conditional exclusion of net462 from Unix builds, and GenAPI project updates to target a single framework (net9.0).
Changes:
- New
notsupported/Microsoft.Data.SqlClient.csprojproject and updatedNotSupported.targetsfor generating PlatformNotSupportedException assemblies via GenAPI - Expanded
build2.projwith test targets (TestMdsFunctional,TestMdsManual,TestMdsUnit), build targets (BuildMdsRef,BuildMdsNotSupported), and comprehensive parameter documentation - Conditional net462 exclusion on Unix, strong-name signing for ref binaries, and GenAPI project simplification to single net9.0 target
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| build2.proj | Major expansion: imports, test/build targets, detailed parameter docs |
| tools/targets/NotSupported.targets | Replaced old GenAPI variable setup with new paths/command, but Exec still uses old vars |
| src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj | New project to generate Not Supported assemblies via GenAPI |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj | Reordered TargetOs/TargetFrameworks, added signing, conditional net462 on Windows only |
| src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj | Added strong-name signing and custom output path under artifacts/ |
| tools/GenAPI/Microsoft.DotNet.GenAPI/Microsoft.DotNet.GenAPI.csproj | Simplified to single net9.0 target, removed custom OutputPath |
| tools/GenAPI/Microsoft.Cci.Extensions/Microsoft.Cci.Extensions.csproj | Removed custom OutputPath |
| src/Microsoft.Data.SqlClient.sln | Added notsupported, GenAPI, and Cci.Extensions projects (no build) |
| .gitignore | Added pattern to ignore generated notsupported .cs files |
src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj
Outdated
Show resolved
Hide resolved
…e projects themselves
Ignore trx test results from git
Adding conditional net462 stuff to stress test Directory.Build.props Adding TestUtilities reference to Azure test
src/Microsoft.Data.SqlClient.Extensions/Azure/test/Azure.Test.csproj
Outdated
Show resolved
Hide resolved
Remove redundant strong naming from common MDS Fix typos as per copilot (why couldn't it find these the first time around??)
…life slightly easier
This was referenced Mar 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of two main changes:
Add test targets to build2.proj
Generate "Not Supported" assemblies from common MDS
Msc Changes
Issues
N/A
Testing
Running targets locally work as expected. Hopefully there are no major issues with the pipelines, since most of the changes don't affect existing pipelines.