Skip to content

Test | Split Data Stream tests#4041

Merged
cheenamalhotra merged 3 commits intomainfrom
dev/cheena/split-data-stream-tests
Mar 13, 2026
Merged

Test | Split Data Stream tests#4041
cheenamalhotra merged 3 commits intomainfrom
dev/cheena/split-data-stream-tests

Conversation

@cheenamalhotra
Copy link
Member

No description provided.

@cheenamalhotra cheenamalhotra requested a review from a team as a code owner March 12, 2026 20:52
Copilot AI review requested due to automatic review settings March 12, 2026 20:52
@github-project-automation github-project-automation bot moved this to To triage in SqlClient Board Mar 12, 2026
@cheenamalhotra cheenamalhotra added the Area\Tests Issues that are targeted to tests or test projects label Mar 12, 2026
mdaigle
mdaigle previously approved these changes Mar 12, 2026
@cheenamalhotra cheenamalhotra moved this from To triage to In review in SqlClient Board Mar 12, 2026
@cheenamalhotra cheenamalhotra changed the title Split Data Stream tests Test | Split Data Stream tests Mar 12, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the manual DataStreamTest suite to run as separate xUnit tests (mostly theories) per scenario, parameterized over available connection strings, instead of running a single “run everything” method.

Changes:

  • Introduces a ConnectionStrings MemberData source based on DataTestUtility.GetConnectionStrings(withEnclave: false).
  • Splits the previous “RunAllTestsForSingleServer_*” entry points into many individual ConditionalTheory tests.
  • Adds try/finally cleanup to ensure the timestamp test drops its temp table.

You can also share your feedback on Copilot code review. Take the survey.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


You can also share your feedback on Copilot code review. Take the survey.

mdaigle
mdaigle previously approved these changes Mar 12, 2026
@cheenamalhotra cheenamalhotra force-pushed the dev/cheena/split-data-stream-tests branch from e0b0b35 to c994d1a Compare March 12, 2026 22:59
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.05%. Comparing base (3f9246c) to head (c994d1a).
⚠️ Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3f9246c) and HEAD (c994d1a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3f9246c) HEAD (c994d1a)
CI-SqlClient 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4041      +/-   ##
==========================================
- Coverage   72.87%   65.05%   -7.83%     
==========================================
  Files         287      282       -5     
  Lines       43134    66043   +22909     
==========================================
+ Hits        31432    42961   +11529     
- Misses      11702    23082   +11380     
Flag Coverage Δ
CI-SqlClient ?
PR-SqlClient-Project 65.05% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paulmedynski paulmedynski added this to the 7.0.0 milestone Mar 13, 2026
@paulmedynski paulmedynski self-assigned this Mar 13, 2026
@cheenamalhotra cheenamalhotra merged commit e099770 into main Mar 13, 2026
296 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/cheena/split-data-stream-tests branch March 13, 2026 17:55
@github-project-automation github-project-automation bot moved this from In review to Done in SqlClient Board Mar 13, 2026
This was referenced Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Tests Issues that are targeted to tests or test projects

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants