Merged
Conversation
… a single baseline file.
…nputParameter, and TvpColumnBoundaries SqlVariantParameter: All 4 variants were identical, consolidated to a single file. StreamInputParameter: Azure variants were identical to non-Azure, removed duplicates (Debug/Release distinction preserved). TvpColumnBoundaries: Debug/Release variants were identical, consolidated to non-Azure and Azure files. Also fixes csproj references for all baseline files including DateTimeVariant from prior commit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates duplicate ManualTests baseline (.bsl) files under tests/ManualTests/SQL/ParameterTest and updates the corresponding manual test harnesses to reference the new unified baselines. This reduces baseline maintenance overhead while keeping the manual baseline comparison behavior intact.
Changes:
- Removed now-redundant Debug/Release and Azure/non-Azure baseline variants for several ParameterTest scenarios.
- Added unified baseline files (
DateTimeVariant.bsl,SqlVariantParameter.bsl,TvpColumnBoundaries.bsl,TvpColumnBoundaries_Azure.bsl) and updated tests to reference them. - Updated
Microsoft.Data.SqlClient.ManualTests.csprojcontent items to copy only the consolidated baselines to test output.
Reviewed changes
Copilot reviewed 15 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpColumnBoundaries_ReleaseMode_Azure.bsl | Removed duplicate Azure baseline in favor of consolidated baselines. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpColumnBoundaries_ReleaseMode.bsl | Removed duplicate Release baseline in favor of consolidated baselines. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpColumnBoundaries_Azure.bsl | Added consolidated Azure baseline for TVP column boundary tests. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpColumnBoundaries.bsl | Added consolidated non-Azure baseline for TVP column boundary tests. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/TvpColumnBoundariesTests.cs | Simplified baseline selection to use consolidated baselines. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/StreamInputParameter_ReleaseMode_Azure.bsl | Removed duplicate Azure baseline; test now uses shared Release baseline. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/StreamInputParameter_DebugMode_Azure.bsl | Removed duplicate Azure baseline; test now uses shared Debug baseline. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/StreamInputParameterTests.cs | Simplified baseline selection to Debug vs Release only (no Azure split). |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/SqlVariantParameter_ReleaseMode_Azure.bsl | Removed duplicate Azure baseline; consolidated to a single baseline file. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/SqlVariantParameter_ReleaseMode.bsl | Removed duplicate Release baseline; consolidated to a single baseline file. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/SqlVariantParameter_DebugMode_Azure.bsl | Removed duplicate Azure baseline; consolidated to a single baseline file. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/SqlVariantParameter.bsl | Added consolidated baseline for SqlVariant parameter tests. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/SqlVariantParameterTests.cs | Simplified baseline selection to a single consolidated baseline. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariant_ReleaseMode.bsl | Removed duplicate Release baseline; consolidated to a single baseline file. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/ParameterTest/DateTimeVariantTests.cs | Simplified baseline selection to a single consolidated baseline. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj | Updated content includes/links to copy only consolidated baselines to output. |
You can also share your feedback on Copilot code review. Take the survey.
cheenamalhotra
added
the
Area\Tests
cheenamalhotra
approved these changes
Mar 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4044 +/- ##
==========================================
- Coverage 72.65% 65.24% -7.41%
==========================================
Files 287 282 -5
Lines 43134 66043 +22909
==========================================
+ Hits 31337 43088 +11751
- Misses 11797 22955 +11158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
approved these changes
Mar 13, 2026
This was referenced Mar 18, 2026
This was referenced Mar 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated duplicate baseline files.