[AndroidDependenciesTests] Use platform-tools 34.0.4#8184
Merged
pjcollins merged 1 commit intodotnet:mainfrom Jul 12, 2023
Merged
[AndroidDependenciesTests] Use platform-tools 34.0.4#8184pjcollins merged 1 commit intodotnet:mainfrom
pjcollins merged 1 commit intodotnet:mainfrom
Conversation
The `InstallAndroidDependenciesTest` test has been failing:
_AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package! repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!
Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
jonathanpeppers
approved these changes
Jul 12, 2023
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Otherwise, this seems fine for now. 👍
| TargetSdkVersion = apiLevel.ToString (), | ||
| }; | ||
| const string ExpectedPlatformToolsVersion = "34.0.3"; | ||
| const string ExpectedPlatformToolsVersion = "34.0.4"; |
Member
There was a problem hiding this comment.
Is there a way we could use HttpClient and pull the version out of a file?
dellis1972
approved these changes
Jul 12, 2023
Contributor
dellis1972
left a comment
dellis1972
left a comment
There was a problem hiding this comment.
It would be nice not to have to bump this every few months/weeks.
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 12, 2023
* main: [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 13, 2023
* typemap-per-rid-support: Address comments [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 14, 2023
* main: [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186) [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 14, 2023
* main: [ci] XA.PublishAllLogs publishes all build logs to build artifacts (dotnet#8189) Bump to xamarin/Java.Interop/main@151b03e (dotnet#8188) [Mono.Android] Use PublicApiAnalyzers to ensure we do not break API. (dotnet#8171) [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186) [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 17, 2023
* main: LLVM IR code generator refactoring and updates (dotnet#8140) [ci] XA.PublishAllLogs publishes all build logs to build artifacts (dotnet#8189) Bump to xamarin/Java.Interop/main@151b03e (dotnet#8188) [Mono.Android] Use PublicApiAnalyzers to ensure we do not break API. (dotnet#8171) [Xamarin.Android.Build.Tasks] per-RID assemblies & typemaps (dotnet#8164) [AndroidDependenciesTests] Test both manifest types (dotnet#8186) [AndroidDependenciesTests] Use platform-tools 34.0.4 (dotnet#8184)
jonathanpeppers
pushed a commit
that referenced
this pull request
Jul 17, 2023
The `InstallAndroidDependenciesTest` test has been failing:
_AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package! repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!
Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jul 26, 2023
The `InstallAndroidDependenciesTest` test has been failing:
_AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package! repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!
Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
jonpryor
pushed a commit
that referenced
this pull request
Jul 26, 2023
The `InstallAndroidDependenciesTest` test has been failing:
_AndroidSdkDirectory not set to new SDK path /Users/runner/work/1/a/TestRelease/07-11_21.59.53/temp/InstallAndroidDependenciesTest/android-sdk, probably because Google's repository has a newer platform-tools package! repository2-3.xml contains platform-tools <major>34</major>.<minor>0</minor>.<micro>4</micro>; expected 34.0.3!
Fix this by bumping the platform-tools version that we try to install
during this test to 34.0.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InstallAndroidDependenciesTesttest has been failing:Fix this by bumping the platform-tools version that we try to install during this test to 34.0.4.