[Xamarin.Android.Build.Tasks] remove @(_AndroidAssemblySkipCases)#8622
Merged
jonathanpeppers merged 1 commit intodotnet:mainfrom Jan 10, 2024
Merged
Conversation
In an effort to remove old, unused code, we should be able to remove the following related to the old Android.Support.* libraries: * `Xamarin.Android.SkipCases.projitems` and the `@(_AndroidAssemblySkipCases)` item group. This was a build performance optimization added in 02c07ed that would *skip* a build step that normalized casing for `.dll` files with an embedded `__AndroidLibraryProjects__.zip`. This optimization is not needed at all for `.aar` files. In .NET 9 projects, we don't create or embed `__AndroidLibraryProjects__.zip`, so modern projects don't need this optimization. Instead we bundle a `MyLibrary.aar` alongside `MyLibrary.dll` inside of a `MyLibrary` NuGet package. * Automatic trimming of the `Xamarin.Android.Support.*` assemblies Modern packages mark themselves trimmable with `$(IsTrimmable)` or the assembly-level attribute. Let's just remove the case for `Android.Support` here.
Contributor
|
We've been marking all of our packages as |
Member
Author
I will try it at some point, but there are some Xamarin.Forms app size tests that will probably fail: We might need to move this test to Xamarin.Forms 5.x, as I bet this project's dependencies are ancient. |
dellis1972
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to remove old, unused code, we should be able to remove the following related to the old Android.Support.* libraries:
Xamarin.Android.SkipCases.projitemsand the@(_AndroidAssemblySkipCases)item group.This was a build performance optimization added in 02c07ed that would skip a build step that normalized casing for
.dllfiles with an embedded__AndroidLibraryProjects__.zip. This optimization is not needed at all for.aarfiles.In .NET 9 projects, we don't create or embed
__AndroidLibraryProjects__.zip, so modern projects don't need this optimization. Instead we bundle aMyLibrary.aaralongsideMyLibrary.dllinside of aMyLibraryNuGet package.Xamarin.Android.Support.*assembliesModern packages mark themselves trimmable with
$(IsTrimmable)or the assembly-level attribute. Let's just remove the case forAndroid.Supporthere.