[Xamarin.Android.Build.Tests] Fix ActionBarSherlock URL#8926
Merged
jonathanpeppers merged 1 commit intomainfrom May 7, 2024
Merged
[Xamarin.Android.Build.Tests] Fix ActionBarSherlock URL#8926jonathanpeppers merged 1 commit intomainfrom
jonathanpeppers merged 1 commit intomainfrom
Conversation
On 2024-May-01, xamarin/monodroid-samples was updated so that the `main` branch no longer contained samples for Classic Xamarin.Android. This in turn meant the removal of the ActionBarSherlock sample. This change in turn broke xamarin-android unit tests, which attempt to download this URL, which no longer exists: * <https://github.com/xamarin/monodroid-samples/blob/main/ActionBarSherlock/ActionBarSherlock/Jars/ActionBarSherlock-4.3.1.zip?raw=true> Oops. As part of the removal of Classic Xamarin.Android samples, a new `monodroid-samples/archived-xamarin` branch was created, which is the state of the `main` branch before all old samples were removed. Update the `BindingBuildTest.RemoveEventHandlerResolution()` integration test to use the correct URL for ActionBarSherlock.
jonathanpeppers
approved these changes
May 6, 2024
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
The new URL works for me in a browser, so should fix the test.
Member
|
The new test is green, going to merge to see if our various release branches can be greener:
There are other failures, I think were caused by #8921. I think if a PR is merged between build & test lanes it can cause failures on PRs. |
jonathanpeppers
pushed a commit
that referenced
this pull request
May 7, 2024
On 2024-May-01, xamarin/monodroid-samples was updated so that the `main` branch no longer contained samples for Classic Xamarin.Android. This in turn meant the removal of the ActionBarSherlock sample. This change in turn broke xamarin-android unit tests, which attempt to download this URL, which no longer exists: * <https://github.com/xamarin/monodroid-samples/blob/main/ActionBarSherlock/ActionBarSherlock/Jars/ActionBarSherlock-4.3.1.zip?raw=true> Oops. As part of the removal of Classic Xamarin.Android samples, a new `monodroid-samples/archived-xamarin` branch was created, which is the state of the `main` branch before all old samples were removed. Update the `BindingBuildTest.RemoveEventHandlerResolution()` integration test to use the correct URL for ActionBarSherlock.
jonathanpeppers
pushed a commit
that referenced
this pull request
May 7, 2024
On 2024-May-01, xamarin/monodroid-samples was updated so that the `main` branch no longer contained samples for Classic Xamarin.Android. This in turn meant the removal of the ActionBarSherlock sample. This change in turn broke xamarin-android unit tests, which attempt to download this URL, which no longer exists: * <https://github.com/xamarin/monodroid-samples/blob/main/ActionBarSherlock/ActionBarSherlock/Jars/ActionBarSherlock-4.3.1.zip?raw=true> Oops. As part of the removal of Classic Xamarin.Android samples, a new `monodroid-samples/archived-xamarin` branch was created, which is the state of the `main` branch before all old samples were removed. Update the `BindingBuildTest.RemoveEventHandlerResolution()` integration test to use the correct URL for ActionBarSherlock.
grendello
added a commit
that referenced
this pull request
May 13, 2024
* main: Bump to xamarin/Java.Interop/main@78d5937 (#8935) [docs] Add "Getting Started" docs (#8934) [Xamarin.Android.Build.Tests] Fix ActionBarSherlock URL (#8926) Update README (#8913) Bumps to xamarin/Java.Interop/main@4e893bf (#8924) Bump to dotnet/installer@fa261b952d 9.0.100-preview.5.24253.16 (#8921) [Mono.Android] Dispose of the `RunnableImplementor` on error (#8907) Bump NDK to r26d (#8868)
grendello
added a commit
that referenced
this pull request
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 2024-May-01, xamarin/monodroid-samples was updated so that the
mainbranch no longer contained samples for Classic Xamarin.Android. This in turn meant the removal of the ActionBarSherlock sample.This change in turn broke xamarin-android unit tests, which attempt to download this URL, which no longer exists:
Oops.
As part of the removal of Classic Xamarin.Android samples, a new
monodroid-samples/archived-xamarinbranch was created, which is the state of themainbranch before all old samples were removed.Update the
BindingBuildTest.RemoveEventHandlerResolution()integration test to use the correct URL for ActionBarSherlock.