Update PackageValidationBaselineVersion to 13.1.2#14886
Merged
eerhardt merged 2 commits intomicrosoft:release/13.2from Mar 4, 2026
Merged
Update PackageValidationBaselineVersion to 13.1.2#14886eerhardt merged 2 commits intomicrosoft:release/13.2from
eerhardt merged 2 commits intomicrosoft:release/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14886Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14886" |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the default package validation baseline version used by the src build so API/package validation comparisons run against the latest released package version.
Changes:
- Bump
PackageValidationBaselineVersionfrom13.0.2to13.1.2when package validation is enabled and no explicit baseline is provided.
All the new compat issues are in experimental types.
eerhardt
commented
Mar 4, 2026
| </Suppression> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:Aspire.Hosting.AzureRedisEnterpriseExtensions</Target> |
Member
Author
There was a problem hiding this comment.
This was an experimental API that we removed in 13.1, so it no longer needs a compat suppression.
eerhardt
commented
Mar 4, 2026
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0001</DiagnosticId> | ||
| <Target>T:Aspire.Hosting.ApplicationModel.DeploymentImageTagCallbackAnnotation</Target> |
Member
Author
There was a problem hiding this comment.
These were all removed in 13.1
eerhardt
commented
Mar 4, 2026
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:Aspire.Hosting.ApplicationModel.ResourceExtensions.WithDeploymentImageTag``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},System.Func{Aspire.Hosting.ApplicationModel.DeploymentImageTagCallbackAnnotationContext,System.String})</Target> | ||
| <Target>M:Aspire.Hosting.ParameterProcessor.#ctor(Aspire.Hosting.ApplicationModel.ResourceNotificationService,Aspire.Hosting.ApplicationModel.ResourceLoggerService,Aspire.Hosting.IInteractionService,Microsoft.Extensions.Logging.ILogger{Aspire.Hosting.ParameterProcessor},Aspire.Hosting.DistributedApplicationExecutionContext,Aspire.Hosting.Pipelines.IDeploymentStateManager)</Target> |
Member
Author
There was a problem hiding this comment.
ParameterProcessor, IContainerRuntime, IDeploymentStateManager, IPipelineActivityReporter, and IUserSecretsManager are all experimental
radical
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way our package validation runs against the latest released version.