Skip to content

Update PackageValidationBaselineVersion to 13.1.2 #14886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eerhardt merged 2 commits into from
Mar 4, 2026
+8 −54
Merged

Update PackageValidationBaselineVersion to 13.1.2 #14886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
accf4f6
Update PackageValidationBaselineVersion to 13.1.2
eerhardt Mar 3, 2026
61700bc
Update compat suppressions
eerhardt Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/Aspire.Hosting.Azure.Redis/CompatibilitySuppressions.xml
View file
Open in desktop

This file was deleted.

42 changes: 7 additions & 35 deletions src/Aspire.Hosting/CompatibilitySuppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,72 +1,44 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Aspire.Hosting.ApplicationModel.DeploymentImageTagCallbackAnnotation</Target>
Copy link
Copy Markdown
Member Author

@eerhardt eerhardt Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were all removed in 13.1

<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Aspire.Hosting.ApplicationModel.DeploymentImageTagCallbackAnnotationContext</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Aspire.Hosting.Publishing.ContainerBuildOptions</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0001</DiagnosticId>
<Target>T:Aspire.Hosting.Publishing.IResourceContainerImageBuilder</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Aspire.Hosting.ApplicationModel.ResourceExtensions.WithDeploymentImageTag``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},System.Func{Aspire.Hosting.ApplicationModel.DeploymentImageTagCallbackAnnotationContext,System.String})</Target>
<Target>M:Aspire.Hosting.ParameterProcessor.#ctor(Aspire.Hosting.ApplicationModel.ResourceNotificationService,Aspire.Hosting.ApplicationModel.ResourceLoggerService,Aspire.Hosting.IInteractionService,Microsoft.Extensions.Logging.ILogger{Aspire.Hosting.ParameterProcessor},Aspire.Hosting.DistributedApplicationExecutionContext,Aspire.Hosting.Pipelines.IDeploymentStateManager)</Target>
Copy link
Copy Markdown
Member Author

@eerhardt eerhardt Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParameterProcessor, IContainerRuntime, IDeploymentStateManager, IPipelineActivityReporter, and IUserSecretsManager are all experimental

<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Aspire.Hosting.ApplicationModel.ResourceExtensions.WithDeploymentImageTag``1(Aspire.Hosting.ApplicationModel.IResourceBuilder{``0},System.Func{Aspire.Hosting.ApplicationModel.DeploymentImageTagCallbackAnnotationContext,System.Threading.Tasks.Task{System.String}})</Target>
<Target>M:Aspire.Hosting.Publishing.IContainerRuntime.BuildImageAsync(System.String,System.String,Aspire.Hosting.Publishing.ContainerImageBuildOptions,System.Collections.Generic.Dictionary{System.String,System.String},System.Collections.Generic.Dictionary{System.String,System.String},System.String,System.Threading.CancellationToken)</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
<Target>M:Aspire.Hosting.ParameterProcessor.#ctor(Aspire.Hosting.ApplicationModel.ResourceNotificationService,Aspire.Hosting.ApplicationModel.ResourceLoggerService,Aspire.Hosting.IInteractionService,Microsoft.Extensions.Logging.ILogger{Aspire.Hosting.ParameterProcessor},Aspire.Hosting.DistributedApplicationExecutionContext,Aspire.Hosting.Pipelines.IDeploymentStateManager)</Target>
<DiagnosticId>CP0006</DiagnosticId>
<Target>M:Aspire.Hosting.Pipelines.IDeploymentStateManager.DeleteSectionAsync(Aspire.Hosting.Pipelines.DeploymentStateSection,System.Threading.CancellationToken)</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0006</DiagnosticId>
<Target>M:Aspire.Hosting.Pipelines.IDeploymentStateManager.DeleteSectionAsync(Aspire.Hosting.Pipelines.DeploymentStateSection,System.Threading.CancellationToken)</Target>
<Target>M:Aspire.Hosting.Pipelines.IPipelineActivityReporter.CompletePublishAsync(Aspire.Hosting.Pipelines.PublishCompletionOptions,System.Threading.CancellationToken)</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0006</DiagnosticId>
<Target>M:Aspire.Hosting.Pipelines.IPipelineActivityReporter.CompletePublishAsync(Aspire.Hosting.Pipelines.PublishCompletionOptions,System.Threading.CancellationToken)</Target>
<Target>M:Aspire.Hosting.Publishing.IContainerRuntime.BuildImageAsync(System.String,System.String,Aspire.Hosting.Publishing.ContainerImageBuildOptions,System.Collections.Generic.Dictionary{System.String,System.String},System.Collections.Generic.Dictionary{System.String,Aspire.Hosting.Publishing.BuildImageSecretValue},System.String,System.Threading.CancellationToken)</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0006</DiagnosticId>
<Target>P:Aspire.Hosting.IDeveloperCertificateService.UseForHttps</Target>
<Target>P:Aspire.Hosting.IUserSecretsManager.IsAvailable</Target>
<Left>lib/net8.0/Aspire.Hosting.dll</Left>
<Right>lib/net8.0/Aspire.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<!-- Enabling this rule will cause build failures on undocumented public APIs. -->
<SkipArcadeNoWarnCS1591>true</SkipArcadeNoWarnCS1591>
<EnablePackageValidation Condition="'$(EnablePackageValidation)' == ''">true</EnablePackageValidation>
<PackageValidationBaselineVersion Condition="'$(EnablePackageValidation)' == 'true' and '$(PackageValidationBaselineVersion)' == ''">13.0.2</PackageValidationBaselineVersion>
<PackageValidationBaselineVersion Condition="'$(EnablePackageValidation)' == 'true' and '$(PackageValidationBaselineVersion)' == ''">13.1.2</PackageValidationBaselineVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading