[release/9.2] Don't fail for Azure role assignments in run mode#8807
Merged
danmoseley merged 2 commits intorelease/9.2from Apr 18, 2025
Merged
[release/9.2] Don't fail for Azure role assignments in run mode#8807danmoseley merged 2 commits intorelease/9.2from
danmoseley merged 2 commits intorelease/9.2from
Conversation
We are throwing too early. When users only want to dotnet run their app and use role assignments, we shouldn't be blocking them on using role assignments. Only when you go to publish, should we throw saying that your infrastructure doesn't support targeted role assignments. Fix #8778
…sources. In those cases we still want the default role assignments to apply.
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
danmoseley
approved these changes
Apr 18, 2025
joperezr
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8800 to release/9.2
/cc @eerhardt
Customer Impact
Customers who only want to dotnet run their app and use role assignments will no longer be blocked on using role assignments. Instead of throwing in both run mode and publish mode, changing the behavior to only throw in publish mode. This allows developers to use role assignments without explicitly adding a compute environment (like Azure Container Apps).
Testing
Manually tested the scenario logged - assigning a role to a storage account during dotnet run.
Updated automated tests to respect the new behavior.
Risk
One risk is that customers will now have apps that work in run mode, but fail during publish because the exception is only thrown in publish mode. Publish mode shouldn't be affected at all with this change.
Regression?
No. You couldn't assign role assignments before 9.2.