Rename hosting, routing and error handling metrics to be consistent with OpenTelemetry#49743
Merged
Rename hosting, routing and error handling metrics to be consistent with OpenTelemetry#49743
Conversation
ghost
added
the
JamesNK
changed the title
JamesNK
changed the title
lmolkova
reviewed
Jul 31, 2023
lmolkova
reviewed
Jul 31, 2023
lmolkova
reviewed
Jul 31, 2023
lmolkova
reviewed
Jul 31, 2023
src/Middleware/Diagnostics/test/UnitTests/DeveloperExceptionPageMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
lmolkova
reviewed
Aug 1, 2023
JamesNK
force-pushed
the
jamesnk/rename-hosting-metrics
branch
from
aceacd7 to
8e2a093
Compare
JamesNK
force-pushed
the
jamesnk/rename-hosting-metrics
branch
from
8e2a093 to
11298ff
Compare
noahfalk
approved these changes
Aug 4, 2023
Member
noahfalk
left a comment
noahfalk
left a comment
There was a problem hiding this comment.
Looked good other than those same unit strings
lmolkova
reviewed
Aug 4, 2023
JamesNK
force-pushed
the
jamesnk/rename-hosting-metrics
branch
from
f3351db to
7bcb729
Compare
4 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying changes from lmolkova/semantic-conventions#1
@noahfalk @lmolkova