HybridCache: reflect API merge into runtime - preview 7 backport#56946
Conversation
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
captainsafia
left a comment
There was a problem hiding this comment.
Changes look good to me as far as reflecting the API that was ultimately approved into runtime.
|
Should cherry-pick this into #56962 |
|
@wtgodbe lets see if this works... changed target/base from |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
tested locally - needed to add back a few more "unshipped" (I guess I got carried away with the del) - should build now |
|
@wtgodbe definitely improving - https://github.com/dotnet/aspnetcore/pull/56946/checks?check_run_id=27868375271 still has some unrelated (I hope!) errors in Something is up with "Linux Musl ARM" and "macOS arm64" like they haven't got the updated bits - taking a peek, but EOD here |
f12be00
into
darc-release/9.0-preview7-c259b2cd-b00e-4c3b-b2fb-6b98cf9f247a
HybridCache: reflect API merge into runtime
In runtime 103103, the proposed HybridCache API was moved from a placeholder in aspnetcore into runtime (which owns the Microsoft.Extensions.Caching.Abstractions library). This means that the original API in aspnetcore is now duplicated and redundant. Additionally, runtime requested some minor last-minute API changes (mainly: prefer
cancellationTokenovertokennaming, and preferIEnumerable<string>overIReadOnlyCollection<string>for tags parameter)This PR reflects this merge - removing the duplicated APIs, and fixing the changes impacted by the API delta.
Since 103103 was merged immediately before the preview 7 snap, this will need applying both in
mainandrelease/9.0-preview7after the runtime deps are updated (this is therelease/9.0-preview7version). Until runtime is built and the deps are updated, aspnetcore may be unbuildable.Cross-reference: #56945 (
main)