Add OTEL semantic conventions tags to HTTP server activity

[JamesNK]

This PR adds OTEL telemetry tags to the HTTP activity:

• Microsoft.AspNetCore.Hosting.SuppressActivityOpenTelemetryData now defaults to false. Telemetry is added to activity by default in .NET 11.
• All required attributes are added to telemetry from HTTP server span spec.
• Fixed HTTP request duration metric to include error.type attribute for 500+ response status codes

The goal is to match the metadata set on the activity by OpenTelemetry.Instrumentation.AspNetCore.

Fixes #52439

[Copilot]

Pull request overview

This PR adds OpenTelemetry semantic convention tags to HTTP server activities and metrics in ASP.NET Core, aligning with OTEL specifications. The key change is that telemetry is now enabled by default in .NET 11.

• Changes the default value of Microsoft.AspNetCore.Hosting.SuppressActivityOpenTelemetryData from true to false, enabling OTEL data by default
• Adds required OTEL semantic convention attributes to HTTP activities including http.response.status_code, network.protocol.version, http.route, and error.type
• Implements error.type attribute for HTTP server metrics with 5xx status codes, following OTEL specifications

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/Shared/Diagnostics/RouteDiagnosticsHelpers.cs	Updates comment to reference "telemetry attributes" instead of just "metrics"
src/Hosting/Hosting/src/Internal/HostingTelemetryHelpers.cs	Adds new attribute constants for OTEL semantic conventions and implements IsErrorStatusCode helper method
src/Hosting/Hosting/src/Internal/HostingMetrics.cs	Updates metrics to use attribute constants and adds error.type tag for 5xx status codes
src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs	Changes default to enable OTEL data, adds end tags to activities including error handling logic
src/Hosting/Hosting/test/HostingMetricsTests.cs	Adds comprehensive tests for error.type behavior in metrics with various status codes
src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs	Adds extensive tests for activity tags, error handling, and sampling scenarios

[ghost]

There might be an issue with forwarded headers handling in the current implementation. The attributes server.address, server.port, and url.scheme are currently set at the start of the activity, before the middleware pipeline is executed and the forwarded headers have been processed. This results in incorrect values for these attributes.

The specification recommends setting these attributes based on the processed forwarded headers:

HTTP server instrumentations SHOULD do the best effort when populating server.address and server.port attributes and SHOULD determine them by using the first of the following that applies:

• The original host which may be passed by the reverse proxy in the Forwarded#host, X-Forwarded-Host, or a similar header.
• The :authority pseudo-header in case of HTTP/2 or HTTP/3
• The Host header.

Should these attributes also be set when the activity stops?

[ghost]

Do you plan to add specific support for activity enrichment based on the HttpRequest and HttpResponse , similar to what is available in OpenTelemetry.Instrumentation.AspNetCore? https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/c938a14321ebf64e3ef4f10a679bc3c3d71690e6/src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreTraceInstrumentationOptions.cs#L68-L86
Or is the current recommendation to use a middleware (or similar) to enrich the activity?

[JamesNK]

Do you plan to add specific support for activity enrichment based on the HttpRequest and HttpResponse , similar to what is available in OpenTelemetry.Instrumentation.AspNetCore? open-telemetry/opentelemetry-dotnet-contrib@c938a14/src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreTraceInstrumentationOptions.cs#L68-L86 Or is the current recommendation to use a middleware (or similar) to enrich the activity?

No plans for special events.

[JamesNK]

Should these attributes also be set when the activity stops?

I don't know. I looked at what OpenTelemetry.Instrumentation.AspNetCore does and it doesn't appear to have any special logic. Those tags are set at the same of the request. The guiding principal of this improvement is to match OpenTelemetry.Instrumentation.AspNetCore tag output.

[ghost]

Should these attributes also be set when the activity stops?

I don't know. I looked at what OpenTelemetry.Instrumentation.AspNetCore does and it doesn't appear to have any special logic. Those tags are set at the same of the request. The guiding principal of this improvement is to match OpenTelemetry.Instrumentation.AspNetCore tag output.

There is an open issue in OTel repo because of this behavior: open-telemetry/opentelemetry-dotnet-contrib#2231

[JamesNK]

@BrennanConroy @halter73 Please review when you have some time.

[JamesNK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[JamesNK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[JamesNK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[JamesNK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).