Skip to content

[release/8.0] Add support for hotfix branding#65252

Merged
wtgodbe merged 1 commit intodotnet:release/8.0from
mmitche:allow-hotfix-branding
Feb 2, 2026
Merged

[release/8.0] Add support for hotfix branding#65252
wtgodbe merged 1 commit intodotnet:release/8.0from
mmitche:allow-hotfix-branding

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Jan 28, 2026

Add support for the pre-release label to be "hotfix" for 8.0

Copilot AI review requested due to automatic review settings January 28, 2026 15:27
@mmitche mmitche requested review from a team and wtgodbe as code owners January 28, 2026 15:27
@mmitche mmitche changed the title Add support for hotfix branding [release/8.0] Add support for hotfix branding Jan 28, 2026
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Jan 28, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds support for "hotfix" as an additional pre-release label for ASP.NET Core 8.0 servicing builds, enabling the build system to recognize hotfix builds alongside regular servicing builds.

Changes:

  • Modified the IsServicingBuild condition to accept both "servicing" and "hotfix" as valid pre-release labels

<AspNetCoreMajorMinorVersion>$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</AspNetCoreMajorMinorVersion>
<!-- Servicing builds have different characteristics for the way dependencies, baselines, and versions are handled. -->
<IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' ">true</IsServicingBuild>
<IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' or '$(PreReleaseVersionLabel)' == 'hotfix'">true</IsServicingBuild>
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before the closing quote and angle bracket. For consistency with other conditions in this file (see line 25), there should be a space before the closing ">.

Suggested change
<IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' or '$(PreReleaseVersionLabel)' == 'hotfix'">true</IsServicingBuild>
<IsServicingBuild Condition=" '$(PreReleaseVersionLabel)' == 'servicing' or '$(PreReleaseVersionLabel)' == 'hotfix' ">true</IsServicingBuild>

Copilot uses AI. Check for mistakes.
@wtgodbe wtgodbe merged commit 4b91e95 into dotnet:release/8.0 Feb 2, 2026
28 of 31 checks passed
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.25 Feb 2, 2026
This was referenced Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants