[release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument#65331
Merged
wtgodbe merged 2 commits intorelease/8.0from Feb 5, 2026
Merged
[release/8.0] Don't use netcoreapp2.1 in dotnet-getdocument#65331wtgodbe merged 2 commits intorelease/8.0from
wtgodbe merged 2 commits intorelease/8.0from
Conversation
wtgodbe
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes support for netcoreapp2.1, an unsupported framework, from the dotnet-getdocument and related tools. This is a backport to release/8.0 of PR #64351 that addresses a Component Governance alert.
Changes:
- Removed netcoreapp2.1 from TargetFrameworks in three project files
- Simplified version detection logic in InvokeCommand.cs to use a uniform path construction approach
- Updated NuGet package specification to reference net8.0 instead of netcoreapp2.1
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj | Removed netcoreapp2.1 from TargetFrameworks |
| src/Tools/dotnet-getdocument/src/Commands/InvokeCommand.cs | Simplified framework version logic by removing special case for versions >= 7.0 and obsolete netcoreapp2.1 fallback |
| src/Tools/GetDocumentInsider/src/GetDocument.Insider.csproj | Removed netcoreapp2.1 from TargetFrameworks and its specific package dependency |
| src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.nuspec | Updated file paths from netcoreapp2.1 to net8.0 |
| src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj | Removed netcoreapp2.1 from TargetFrameworks |
This was referenced Mar 10, 2026
Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.24 to 8.0.25
TechnologyEnhancedLearning/TELBlazor#396
Closed
Open
This was referenced Mar 11, 2026
Merged
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #64351, fixes a CG alert