RateLimitingMiddleware implements IDisposable to avoid leaking timers#66435
Open
kvantetore wants to merge 1 commit intodotnet:mainfrom
Open
RateLimitingMiddleware implements IDisposable to avoid leaking timers#66435kvantetore wants to merge 1 commit intodotnet:mainfrom
kvantetore wants to merge 1 commit intodotnet:mainfrom
Conversation
github-actions
Bot
added
the
area-middleware
dotnet-policy-service
Bot
added
the
community-contribution
This was referenced Apr 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RateLimitingMiddleware implements IDisposable to avoid leaking timers
Change RateLimitingMiddleware from convention-based to DI activated and implement IDisposable in order to not leak memory
Description
Most of the implementation is pretty straight forward. The only thing that feels a bit off is the handling of options passed to
UseRateLimiter(..., RateLimiterOptions options)(as opposed to the more idiomatic version passing options during DI registration). I moved some of the initialization code to an internalInitialize(...)and call the initialize method both from the constructor and fromUseRateLimiter(..., RateLimiterOptions options)Fixes #66434