Skip to content

Create msbuild workspace with Release Configuration by default #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qinezh merged 1 commit into from
Feb 27, 2017
Merged

Create msbuild workspace with Release Configuration by default #1356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Microsoft.DocAsCode.Metadata.ManagedReference/ExtractMetadataWorker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ namespace Microsoft.DocAsCode.Metadata.ManagedReference

public sealed class ExtractMetadataWorker : IDisposable
{
private readonly Lazy<MSBuildWorkspace> _workspace = new Lazy<MSBuildWorkspace>(() => MSBuildWorkspace.Create());
private readonly Lazy<MSBuildWorkspace> _workspace = new Lazy<MSBuildWorkspace>(() => MSBuildWorkspace.Create(new Dictionary<string, string>
{
{ "Configuration", "Release" }
Copy link
Copy Markdown
Contributor

@vicancy vicancy Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide a MetadataCommandOption to change?

Copy link
Copy Markdown
Contributor Author

@qinezh qinezh Feb 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with it. The aim of this PR is only to change the default behavior, and I'll provide metadata option in another PR if users need it.

}));
private static readonly string[] SupportedSolutionExtensions = { ".sln" };
private static readonly string[] SupportedProjectName = { "project.json" };
private static readonly string[] SupportedProjectExtensions = { ".csproj", ".vbproj" };
Expand Down