Add .NET Core Samples by richlander · Pull Request #362 · dotnet/dotnet-docker

richlander · 2018-02-12T07:34:55Z

Moved samples from https://github.com/dotnet/dotnet-docker-samples
Took a different approach from the original samples (which had many top-level directories). The new approach has many Dockerfiles in the same directory. I also took more opportunities to make the examples more OS-agnostic.
I factored out instructions that have use for multiple scenarios.

MichaelSimons

I like the overall change. My comments are pretty minor.

MichaelSimons · 2018-02-12T19:40:24Z

+See the following related .NET Core Docker Hub repos:
+
+* [microsoft/aspnetcore](https://hub.docker.com/r/microsoft/aspnetcore/) for ASP.NET Core images.
+* [microsoft/dotnet](https://hub.docker.com/r/microsoft/dotnet/) for .NET Core images.


Should dotnet-nightly be listed as well? The Alpine based samples have a dependency on it.

MichaelSimons · 2018-02-12T19:43:02Z

+### Optimizing Container Size
+
+* [.NET Core Alpine Docker Sample](dotnetapp/README.md) - This [sample](dotnetapp/Dockerfile.alpine) builds, tests and runs an application using Alpine.
+* [.NET Core self-contained Sample](dotnetapp/dotnet-docker-selfcontained.md) -- This sample builds and runs an application as a self-contained application.


(nit) uses two dashes -- whereas the others only use one.

MichaelSimons · 2018-02-12T19:44:25Z

+
+### ARM32 / Raspberry Pi
+
+* [.NET Core ARM32 Docker Sample](dotnetapp/README.md) - This [sample](dotnetapp/Dockerfile.arm32) builds and runs an application with Debian on ARM32 (works on Raspberry Pi).


Should these readme links go to the dotnet-docker-arm32.md?

MichaelSimons · 2018-02-12T19:47:12Z

+```console
+cd samples
+cd dotnetapp
+docker build -t dotnetapp .


I sometimes lean toward including --pull to avoid any issues customers may hit with old images lingering around.

MichaelSimons · 2018-02-12T19:51:28Z

+## Build and run the sample for ARM32
+
+You can build and run the sample for [ARM32 and Raspberry Pi](dotnet-docker-arm32.md) with [Build .NET Core Applications for Raspberry Pi with Docker](dotnet-docker-arm32.md) instructions.
+


I was expecting a section that mentions and links to the self contained readme.

MichaelSimons · 2018-02-12T20:45:57Z

@@ -0,0 +1,5 @@
+bin/


I think a similar .dockerignore should exist for the aspnetapp.

MichaelSimons · 2018-02-12T20:48:48Z

@@ -0,0 +1,71 @@
+Microsoft Visual Studio Solution File, Format Version 12.00


Why don't the solutions include all of the Dockerfiles?

I guess it is a question of what the SLN is should represent ... should it represent all of the assets (like you are suggesting) or be a more typical SLN with just typical assets (not duplicate Dockerfiles). Certainly, it should contain at least a Dockerfile. Thoughts?

My viewpoint was not necessarily that a sln would ever have this many Dockerfiles. I do see customers as possibly having more than one in which case all Dockerfiles would be included. In this particular case, I don't want customers to open the sln and overlook the permutations of the Dockerfiles included in the sample.

MichaelSimons · 2018-02-12T21:05:29Z

+
+## Build and run the sample for Linux ARM32 with Docker
+
+You need to build the [sample](Dockerfile.arm32) on Windows. This requirement is due to the .NET Core SDK not being currently supported on ARM32. The instructions assume that you are in the root of the repository.


MacOS would also work too?

Is it just Linux that won't work?

Tested it everywhere. It works. I somehow got the idea it wouldn't. Updated text.

MichaelSimons · 2018-02-12T21:07:27Z

+* [ASP.NET Core Getting Started Tutorials](https://www.asp.net/get-started)
+* [.NET Core Production Docker sample](../dotnetapp-prod/README.md)
+* [.NET Core Docker samples](../README.md)
+* [.NET Framework Docker samples](https://github.com/Microsoft/dotnet-framework-docker-samples)


Would it make sense to call out this includes ASP.NET samples? In this context it seems useful.

Do you mean the .NET Framework Samples?

Yes - the .NET Framework Docker samples include full fx ASP.NET samples.

MichaelSimons · 2018-02-12T21:25:06Z

@@ -0,0 +1,33 @@
+FROM microsoft/dotnet:sdk AS build


It may be a good idea to include linux in the filename since the Dockerfile is tied to linux. Trying to build it in a Windows container environment has a little strange behavior as the first stage will succeed.

MichaelSimons · 2018-02-21T15:30:21Z

+
+The samples show various ways to use .NET Core and Docker together. You can use the samples as the basis of your own Docker images or just to play.
+
+The samples exercise various levels of functionality. The [.NET Core Docker sample](dotnetapp/README.md) includes the most functionality, including build and unit testing. Other samples do less. You can decide what is the right level of functionality for your use case, either copy/pasting in more delete functionality or deleting it. The samples include instructions on how to build them, with and without Docker.


wording - either copy/pasting in more delete functionality or deleting it Seems like the first delete should be removed.

MichaelSimons · 2018-02-21T15:31:14Z

+Type the following command to run a sample with [Docker](https://www.docker.com/products/docker):
+
+```console
+docker run microsoft/dotnet-samples


consider adding the use of --rm

MichaelSimons · 2018-02-21T15:33:02Z

+## ARM32 / Raspberry Pi
+
+* [.NET Core ARM32 Docker Sample](dotnetapp/dotnet-docker-arm32.md) - This [sample](dotnetapp/Dockerfile.linux-arm32) builds and runs an application with Debian on ARM32 (works on Raspberry Pi).
+* [ASP.NET Core ARM32 Docker Sample](aspnetapp/README.md) - This [sample](aspnetapp/Dockerfile.linux-arm32) builds and runs an application with Debian on ARM32 (works on Raspberry Pi).


Should call out ASP.NET in the description - This sample builds and runs an ASP.NET application...

MichaelSimons · 2018-02-21T15:34:44Z

+
+* [microsoft/aspnet](https://hub.docker.com/r/microsoft/aspnet/) for ASP.NET Web Forms and MVC images.
+* [microsoft/dotnet-framework](https://hub.docker.com/r/microsoft/dotnet-framework/) for .NET Framework images (for web applications, see microsoft/aspnet).
+* [microsoft/dotnet-framework-build](https://hub.docker.com/r/microsoft/dotnet-framework-build/) for .NET Framework images (for web applications, see microsoft/aspnet).


I wasn't expecting (for web applications, see microsoft/aspnet)

MichaelSimons · 2018-02-21T15:38:06Z

+
+namespace Tests
+{
+    public class ConsoleTests


Any reason to not align the name of the two test classes with the classes they are intended to test? ConsoleUtilsTests and StringUtilsTests?

MichaelSimons · 2018-02-21T16:58:03Z

+* [Multi-arch sample with build and unit testing](Dockerfile)
+* [Multi-arch basic sample](Dockerfile.basic)
+* [Alpine sample with build and unit testing](Dockerfile.alpine)
+* [Alpine basic sample, with Globalization enabled](Dockerfile.alpinewithglobalization)


MichaelSimons · 2018-02-21T17:10:46Z

+VisualStudioVersion = 15.0.26124.0
+MinimumVisualStudioVersion = 15.0.26124.0
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "aspnetapp", "aspnetapp\aspnetapp.csproj", "{5FDCC1ED-9F59-47ED-969D-5E463CDD8D52}"
+EndProject


Should include .dockerignore and Dockerfile.

MichaelSimons · 2018-02-21T17:13:21Z

@@ -0,0 +1,19 @@
+FROM microsoft/dotnet:2.0-sdk AS build


Why not base the sample on the aspnetcore images?

cause the final result is nearly 100MB diff, due to this line: https://github.com/aspnet/aspnet-docker/blob/master/2.0/stretch/runtime/Dockerfile#L8. This will only get worse for 2.0. For 2.1, it will be different.

Really, 100MB? I'm surprised. I would have thought it would be about equal because you end up publishing those assemblies in your local publish directory when setting /p:PublishWithAspNetCoreTargetManifest="false".

Also, you lose out on crossgen and fast startup by not using the runtime store.

MichaelSimons · 2018-02-21T17:19:03Z

+* [ASP.NET Core Getting Started Tutorials](https://www.asp.net/get-started)
+* [.NET Core Production Docker sample](../dotnetapp-prod/README.md)
+* [.NET Core Docker samples](../README.md)
+* [.NET Framework and and ASP.NET Docker samples](https://github.com/Microsoft/dotnet-framework-docker-samples)


Perhaps it would be more appropriate to use and and and here instead of just and and 😸

MichaelSimons · 2018-02-21T17:29:06Z

@@ -0,0 +1,71 @@
+Microsoft Visual Studio Solution File, Format Version 12.00


My viewpoint was not necessarily that a sln would ever have this many Dockerfiles. I do see customers as possibly having more than one in which case all Dockerfiles would be included. In this particular case, I don't want customers to open the sln and overlook the permutations of the Dockerfiles included in the sample.

MichaelSimons · 2018-02-21T18:50:03Z

This PR fixes the following issues:
dotnet/dotnet-docker-samples#99
dotnet/dotnet-docker-samples#105
dotnet/dotnet-docker-samples#108

richlander · 2018-02-25T06:42:02Z

I think that I've resolved all of your feedback now @MichaelSimons . Thanks for all of it! I also made several other changes that you'll notice.

richlander · 2018-02-25T07:09:26Z

I just added a README.DockerHub.md. I updated the tags to demonstrate what I think we need. I know that your manifest tool will generate the same content. This file is intended to be a spec and a placeholder.

MichaelSimons

LGTM - few minor comments

MichaelSimons · 2018-02-26T16:18:17Z

+
+This repo contains samples that demonstrate various .NET Core Docker configurations.
+
+You can see the source for these samples at [dotnet/dotnet-docker/samples](https://github.com/dotnet/dotnet-docker/tree/master/samples/README.md) on GitHub. They can be updated by pull request.


This doesn't read well to me - "They can be updated by pull request." How about something like "They can be updated by creating a pull request"?

MichaelSimons · 2018-02-26T16:23:13Z

+
+### Issues
+
+If you have any problems with or questions about this image, please contact us through a [GitHub issue](https://github.com/dotnet/dotnet-docker/samples/issues).


The link doesn't seem right.

MichaelSimons · 2018-02-26T16:26:16Z

+The `dotnetapp` tag is a sample console application that depends on the [.NET Core Runtime image](https://hub.docker.com/r/microsoft/dotnet). You can run it in a container by running the following command.
+
+```console
+docker run microsoft/dotnet-samples:dotnetapp


Should include --rm

MichaelSimons · 2018-02-26T16:37:46Z

+
+## Build and run the sample for ARM32
+
+You can build and run the sample for [ARM32 and Raspberry Pi](dotnet-docker-arm32.md) with [Build .NET Core Applications for Raspberry Pi with Docker](dotnet-docker-arm32.md) instructions.


It is a little odd that both the hyperlinks that are so close together point to the same thing.

MichaelSimons · 2018-02-26T16:39:24Z

@@ -0,0 +1,20 @@
+FROM microsoft/dotnet:sdk AS build


I think this should be 2.0-sdk versus sdk

MichaelSimons · 2018-02-26T16:43:07Z

+        ConsoleUtils.PrintStringWithRandomColor(bot);
+
+        WriteLine("**Environment**");
+        WriteLine($"Platform: .NET Core 2.0");


Still not crazy about this hard coded value. It seems misleading when used in the Alpine scenario which is based on 2.1.

MichaelSimons · 2018-02-26T17:01:46Z

+
+The following example demonstrates how to create a private ACR Registry. Once an image is in ACR, it is easy to deploy it to ACI.
+
+The instructions use example values that need to be changed to for your environment, specifically the password location, the registry name and the user account. More simply, make sure to change "rich" and "richlander" to something else.


I like how this is called out more in the push-image-to-dockerhub.md

MichaelSimons · 2018-02-26T17:08:50Z

+# directories
+bin/
+obj/
+out/


I question if the two .dockerignore files have the correct paths specified for bin, obj, and out. I think they should all be prefixed with **/. Right now it you build the app locally, the bin and obj are getting copied into the image from the host because the app is in a subfolder of where the .dockerignore files reside.

MichaelSimons · 2018-02-26T17:11:49Z

+172.25.157.148
+```
+
+## Build and run the sample for Linux ARM32 with Docker


Curious why this isn't broken out into a separate md file like what was doen for the dotnetapp?

MichaelSimons · 2018-02-26T17:13:36Z

+docker run --rm -p 8000:80 --name aspnetcore_sample microsoft/dotnet-samples:aspnetapp
+```
+
+After the application starts, navigate to `http://localhost:8000` in your web browser. You need to navigate to the application via IP address instead of `localhost` for Windows containers, which is demonstrated in one of the following sections.


How about providing a link to the View the ASP.NET Core app in a running container on Windows section?

MichaelSimons

LGTM

richlander added 17 commits February 7, 2018 07:43

Add Docker samples

359e44b

Add alternative dockerfiles

8a64786

Update README

155f68b

Add aspnetapp sample

3f1416d

Update samples README

ccb99da

Update aspnet app

0be73b4

Remove dotnet-specific Dockerfile

4108084

Factor READMEs

2aacdb4

Add self-contained samples

99afd47

Remove additional None files from project

69f1e5c

Add ARM32 to aspnet sample

a7a2ab2

Link samples together

9820b54

Update registry links

49f092b

Fix registry links

c91e2df

Fix DockerHub string

eb98b1f

Fix registry links

db78b09

Update self-contained section

ac11ecb

richlander mentioned this pull request Feb 12, 2018

Confusing separation of dev/prod dotnet/dotnet-docker-samples#108

Closed

MichaelSimons reviewed Feb 12, 2018

View reviewed changes

richlander added 10 commits February 12, 2018 17:50

Add ACI doc

e2a2da5

Update ACI instructions

bb55947

Add sections to ACI doc

48b2c9d

Update samples - wip

fa71665

Update instructions

8372490

Update per feedback

d20ff13

Update per feedback

dca4d3d

Update per feedback

a6559bb

Add link to self-contained doc

9a83066

Update container docs

28e6c8e

MichaelSimons reviewed Feb 21, 2018

View reviewed changes

richlander added 3 commits February 23, 2018 16:38

Update per feedback

7a95aba

Add *.md to .dockerignore

8b560e7

Update per feedback

c5e243a

richlander force-pushed the samples branch from 201c427 to c5e243a Compare February 25, 2018 06:38

Add README for DockerHub

b18d34c

richlander added 5 commits February 24, 2018 23:41

Update per grammar check

addf3cb

Update per feedback

f2ac07a

Update branch in URL

95ccaec

Update Dockerfile references

41578a4

Update ASP.NET Core docker commandline

97d7066

MichaelSimons approved these changes Feb 26, 2018

View reviewed changes

richlander added 2 commits February 26, 2018 10:37

Update per feedback

bcd11bc

Update per feedback

9cdbf4e

MichaelSimons approved these changes Feb 26, 2018

View reviewed changes

richlander merged commit 626c3fe into master Feb 26, 2018

richlander deleted the samples branch February 26, 2018 21:17

This was referenced Feb 27, 2018

Rename dotnetapp-prod to dotnetapp dotnet/dotnet-docker-samples#105

Closed

.NET Core Docker Samples have moved dotnet/dotnet-docker-samples#112

Open

.NET Core Docker Samples have moved #399

Closed

Refactor readme to account for refactored samples #408

Closed


		### ARM32 / Raspberry Pi

		* [.NET Core ARM32 Docker Sample](dotnetapp/README.md) - This [sample](dotnetapp/Dockerfile.arm32) builds and runs an application with Debian on ARM32 (works on Raspberry Pi).

		## Build and run the sample for ARM32

		You can build and run the sample for [ARM32 and Raspberry Pi](dotnet-docker-arm32.md) with [Build .NET Core Applications for Raspberry Pi with Docker](dotnet-docker-arm32.md) instructions.

		@@ -0,0 +1,71 @@
		Microsoft Visual Studio Solution File, Format Version 12.00


		## Build and run the sample for Linux ARM32 with Docker

		You need to build the [sample](Dockerfile.arm32) on Windows. This requirement is due to the .NET Core SDK not being currently supported on ARM32. The instructions assume that you are in the root of the repository.


		The samples show various ways to use .NET Core and Docker together. You can use the samples as the basis of your own Docker images or just to play.

		The samples exercise various levels of functionality. The [.NET Core Docker sample](dotnetapp/README.md) includes the most functionality, including build and unit testing. Other samples do less. You can decide what is the right level of functionality for your use case, either copy/pasting in more delete functionality or deleting it. The samples include instructions on how to build them, with and without Docker.


		This repo contains samples that demonstrate various .NET Core Docker configurations.

		You can see the source for these samples at [dotnet/dotnet-docker/samples](https://github.com/dotnet/dotnet-docker/tree/master/samples/README.md) on GitHub. They can be updated by pull request.


		### Issues

		If you have any problems with or questions about this image, please contact us through a [GitHub issue](https://github.com/dotnet/dotnet-docker/samples/issues).


		The following example demonstrates how to create a private ACR Registry. Once an image is in ACR, it is easy to deploy it to ACI.

		The instructions use example values that need to be changed to for your environment, specifically the password location, the registry name and the user account. More simply, make sure to change "rich" and "richlander" to something else.

Conversation

richlander commented Feb 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichaelSimons left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichaelSimons commented Feb 21, 2018

Uh oh!

richlander commented Feb 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richlander commented Feb 25, 2018

Uh oh!

MichaelSimons left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

richlander commented Feb 12, 2018 •

edited

Loading

richlander commented Feb 25, 2018 •

edited

Loading