Model (seed) data with newlines may result in SQL exceptions

[starteNCS]

After updating to net5.0 and therefore updating my efcore dependencies I run into an error when starting my tests.

The error Microsoft.Data.Sqlite.SqliteException : SQLite Error 1: 'Expression tree is too large (maximum depth 1000)'. is thrown and I cannot find any resources about the error in combination with efcore.

Here is the way we initalize the Db

services.AddScoped(p =>
            DbContextOptionsFactory<TContext>(
            p,
            (sp, options) => options
                .ConfigureWarnings(b => b.Log(CoreEventId.ManyServiceProvidersCreatedWarning))
                .UseLazyLoadingProxies()
                .UseSqlite(connection)));

And this chunk of code throws the error

ApplicationDbContext applicationDbContext =
                            scopedServices.GetRequiredService<ApplicationDbContext>();
var creator1 = (RelationalDatabaseCreator) applicationDbContext.Database
                            .GetService<IRelationalDatabaseCreator>();
creator1.CreateTables();

  Message: 
    Microsoft.Data.Sqlite.SqliteException : SQLite Error 1: 'Expression tree is too large (maximum depth 1000)'.
  Stack Trace: 
    SqliteException.ThrowExceptionForRC(Int32 rc, sqlite3 db)
    SqliteCommand.PrepareAndEnumerateStatements(Stopwatch timer)+MoveNext()
    SqliteCommand.GetStatements(Stopwatch timer)+MoveNext()
    SqliteDataReader.NextResult()
    SqliteCommand.ExecuteReader(CommandBehavior behavior)
    SqliteCommand.ExecuteReader()
    SqliteCommand.ExecuteNonQuery()
    RelationalCommand.ExecuteNonQuery(RelationalCommandParameterObject parameterObject)
    MigrationCommand.ExecuteNonQuery(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues)
    MigrationCommandExecutor.ExecuteNonQuery(IEnumerable`1 migrationCommands, IRelationalConnection connection)
    RelationalDatabaseCreator.CreateTables()
    TenantWebApplicationFactory`1.<ConfigureWebHost>b__2_0(IServiceCollection services) line 63
    <>c__DisplayClass10_0.<ConfigureServices>b__0(WebHostBuilderContext context, IServiceCollection services)
    <>c__DisplayClass11_0.<ConfigureServices>b__0(HostBuilderContext context, IServiceCollection builder)
    HostBuilder.CreateServiceProvider()
    HostBuilder.Build()
    WebApplicationFactory`1.CreateHost(IHostBuilder builder)
    DelegatedWebApplicationFactory.CreateHost(IHostBuilder builder)
    WebApplicationFactory`1.EnsureServer()
    WebApplicationFactory`1.CreateDefaultClient(DelegatingHandler[] handlers)
    WebApplicationFactory`1.CreateDefaultClient(Uri baseAddress, DelegatingHandler[] handlers)
    WebApplicationFactory`1.CreateClient(WebApplicationFactoryClientOptions options)
    WebApplicationFactory`1.CreateClient()
    <.ctor>b__9_0() line 30
    Lazy`1.ViaFactory(LazyThreadSafetyMode mode)
    Lazy`1.ExecutionAndPublication(LazyHelper executionAndPublication, Boolean useDefaultConstructor)
    Lazy`1.CreateValue()
    Lazy`1.get_Value()
    TenantTestFixture.get_ServerClient() line 23
    TenantTestFixture.ctor() line 57

EF Core version: 5.0
Database provider: SQLite
Target framework: .NET 5.0
Operating system: Windows 10
IDE: Visual Studio 2019 16.8.1

[ajcvickers]

@starteNCS Please attach a small, runnable project or post a small, runnable code listing that reproduces what you are seeing so that we can investigate.

[starteNCS]

I cannot reproduce the Error in a smaller project. Is there any way I could email you the Project? I am not allowed to upload it on Github.

[starteNCS]

I let EF give me the SQL he was trying to execute with

creator1.GenerateCreateScript();

and ran it in an SQLite Editor. The Tables are generated even though the Error is thrown. Is it possible, that SQLite has a max amount of Entities that it can turn into tables? And if so, can I split the generation into two or more parts to be run separately?

[ajcvickers]

@starteNCS How many entity types do you have?

[starteNCS]

Its 10 Entities with arround 7 to 10 Properties

[ajcvickers]

@starteNCS That's a small number of entity types; should be fine. If the project is in a form that I can easily execute the code and reproduce the issue, then you can send it to my work address (avickers @ the place I work) and I'll take a quick look.

[ajcvickers]

@starteNCS Unfortunately, the solution does not build for me. It references packages that are not available on NuGet.org.

[starteNCS]

I am sorry for that. I sent you another email with a new version, that should have no problem with it

[ajcvickers]

@starteNCS Thanks--I was able to reproduce the issue.

@bricelam The root cause here seems to be the same as for #23518. The seed data in this case is one huge string with 1000s of newlines in it. However, without revealing any confidential information, it actually seems to me to be a reasonable use of seed data--we can discuss in triage.

[starteNCS]

Is there any way to "override" my entity-configuration for the tests, so that I can at least use my tests right now?

[ajcvickers]

@starteNCS Your tests ran for me when I removed the HasData calls in the model builder. You could do this conditionally when targeting the SQLite database with something like:

    protected override void OnModelCreating(ModelBuilder modelBuilder)
    {
        if (Database.IsSqlite())
        {
            ...
        }
    }