Make EngineEdition more readable

[ErikEJ]

Fixes #31037

[roji]

Should we just type _engineEdition as EngineEdition? This way we can remove all the pesky casts.

[ErikEJ]

How will that work with other/new engineedition values?

[roji]

How will that work with other/new engineedition values?

It's always possible to cast the int read from the database to the enum - even if a label isn't defined for it. If we ever need to actually check that value, at that point we'd need to add a label for it, no?

[ErikEJ]

So in the case of an int value of f.ex. 5 you can still do this?? Guess I know too little about enums 😅

(EngineEdition)_engineEdition

[roji]

Yep :) You can always cast an enum to its underlying type (e.g. int) and vice versa.

[ErikEJ]

@roji Updated

[roji]

Thanks @ErikEJ!