[release/8.0] Handle more types of value converters in the compiled model#31861
Merged
ajcvickers merged 2 commits intorelease/8.0from Sep 28, 2023
Merged
[release/8.0] Handle more types of value converters in the compiled model#31861ajcvickers merged 2 commits intorelease/8.0from
ajcvickers merged 2 commits intorelease/8.0from
Conversation
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…odel Fixes #31827 ### Description We changed the way value converters are saved in the compiled model as part of moving towards AOT. Some built-in converters were not working correctly with this change. ### Customer impact Crash when compiling the model. ### How found Customer reported. ### Regression Yes. ### Testing Tests added for built-in converters. ### Risk Low.
ajcvickers
force-pushed
the
230925_StringingMeAlong
branch
from
b63c901 to
ad9cd59
Compare
AndriySvyryd
approved these changes
Sep 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31827
Description
We changed the way value converters are saved in the compiled model as part of moving towards AOT. Some built-in converters were not working correctly with this change.
Customer impact
Crash when compiling the model.
How found
Customer reported.
Regression
Yes.
Testing
Tests added for built-in converters.
Risk
Low.